486774 - Quell compiler warning on SunPro CC in addition to GCC

Status: RESOLVED WONTFIX

(Core :: JavaScript Engine, defect)

Description

[Andrew Paprocki]

Attachment: patch to extend existing #ifdef logic to cover __SUNPRO_CC

Currently, code checks for GCC to initialize variables to NULL to prevent a compiler warning. SunPro CC also emits warnings, so the #ifdef should be extended to cover that compiler as well.

I'd vote that rather than adding more #ifdef noise, the variables just always be initialized to NULL. I'll attach patches for both options and leave it up to the reviewer.

Comment 1

[Andrew Paprocki]

Attachment: patch to remove #ifdefs completely and initialize vars to NULL

Comment 2

[Andreas Gal :gal]

Comment on attachment 370973 [details] [diff] [review]
patch to extend existing #ifdef logic to cover __SUNPRO_CC

Not brendan but this looks harmless.

Comment 3

[Andreas Gal :gal]

Comment on attachment 370975 [details] [diff] [review]
patch to remove #ifdefs completely and initialize vars to NULL

I am fine with either. Any compiler worth a penny will eliminate the redundant NULL writes.

Comment 4

[Andrew Paprocki]

Attachment: Always initialize two stack variables instead of only when using g++.

Rebased old patch, simply initialize the two stack vars to NULL to get rid of ugly __GNUC__ ifdef since other compilers complain too.

Comment 5

[David Mandelin [:dmandelin]]

Comment on attachment 569265 [details] [diff] [review]
Always initialize two stack variables instead of only when using g++.

Assuming this doesn't apply at this point. Feel free to r? me for it if it still works and you want it.

Comment 6

[Andrew Paprocki]

Code is obsolete now.