All users were logged out of Bugzilla on October 13th, 2018
Created attachment 370987 [details] [diff] [review] patch to move anonymous func ptr to typedef SunPro CC compiler will complain about the anonymous mapfun function pointer because the function declaration is inside of an extern "C" block. Simply moving it out to a typedef shuts up the compiler: "jsscan.cpp", line 147: Warning: function void(void(*)(const char*)) overloads extern "C" void(extern "C" void(*)(const char*)) because of different language linkages. Patch creates a JSMapKeywordsFun typedef to silence the warning.
Created attachment 370988 [details] [diff] [review] patch to move anonymous func ptr to typedef removed accidental extra newline in the previous patch
Attachment #370988 - Flags: review?(brendan) → review+
Comment on attachment 370988 [details] [diff] [review] patch to move anonymous func ptr to typedef >+typedef void (*JSMapKeywordsFun)(const char *); Nit: function maps one keyword at a time, so the name should use Keyword, singular. I think we should get rid of this old friend API, but for this bug, with the above fix, r=me. /be
Created attachment 370989 [details] [diff] [review] patch to move anonymous func ptr to typedef updated patch for review nit
This should go into tracemonkey, not directly m-c
Could you guys please take care of your TM landings? They tend to get dusty in the checkin-needed queue.
Whiteboard: [c-n: tracemonkey first]
Version: unspecified → Trunk
Whiteboard: [c-n: tracemonkey first] → [c-n: tracemonkey]
Land it or wontfix it: it's grotesque that the tracemonkey checkin-needed queue is eight months long.
Whiteboard: [c-n: tracemonkey] → fixed-in-tracemonkey
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.