Closed
Bug 486780
Opened 15 years ago
Closed 15 years ago
EndUnless used in installer where EndIf should be used
Categories
(Firefox :: Installer, defect)
Tracking
()
RESOLVED
FIXED
Firefox 3.5b4
People
(Reporter: mcsmurf, Assigned: robert.strong.bugs)
Details
(Keywords: fixed1.9.1)
Attachments
(1 file)
|
936 bytes,
patch
|
jimm
:
review+
beltzner
:
approval1.9.1+
|
Details | Diff | Splinter Review |
See http://hg.mozilla.org/mozilla-central/annotate/6f3c2171bbb2/browser/installer/windows/nsis/installer.nsi#l471, EndUnless does not match the {If} ... tag in line 465. Looks like NSIS seems to ignore/correct this?
|
Assignee | |
Comment 1•15 years ago
|
||
Thanks for finding / reporting this Frank.
Assignee: nobody → robert.bugzilla
Status: NEW → ASSIGNED
Attachment #372734 -
Flags: review?(jmathies)
|
|
||
Updated•15 years ago
|
Attachment #372734 -
Flags: review?(jmathies) → review+
|
|
Assignee | |
Comment 2•15 years ago
|
||
Pushed to mozilla-central http://hg.mozilla.org/mozilla-central/rev/e00231915b17
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 3•15 years ago
|
||
Comment on attachment 372734 [details] [diff] [review] patch Drivers, this is a very simple fix I'd like for 1.9.1 that has no risk.
Attachment #372734 -
Flags: approval1.9.1?
|
||
Updated•15 years ago
|
Attachment #372734 -
Flags: approval1.9.1? → approval1.9.1+
|
|
||
Comment 4•15 years ago
|
||
Comment on attachment 372734 [details] [diff] [review] patch a191=beltzner
|
|
Assignee | |
Comment 5•15 years ago
|
||
Pushed to mozilla-1.9.1 http://hg.mozilla.org/releases/mozilla-1.9.1/rev/02a79ed478dd
Keywords: fixed1.9.1
Target Milestone: --- → Firefox 3.5b4
You need to log in
before you can comment on or make changes to this bug.
Description
•