486857 - AIX Compilation error for trunk build source nsAccessibleTreeWalker.cpp : ../../../dist/include/xpcom/nsCOMPtr.h", line 187.30: 1540-0408 (S) The base class "nsIDOMNode" is declared but not defined

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Shailen]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.8) Gecko/2009032609 Firefox/3.0.8
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.8) Gecko/2009032609 Firefox/3.0.8

While compiling trunk build on AIX, getting below compilation error - 

"../../../dist/include/xpcom/nsCOMPtr.h", line 187.30: 1540-0408 (S) The base class "nsIDOMNode" is declared but not defined.
"../../../dist/include/xpcom/nsCOMPtr.h", line 187.7: 1540-0700 (I) The previous message was produced while processing "class nsDerivedSafe<nsIDOMNode>".
gmake[1]: *** [nsAccessibleTreeWalker.o] Error 1
gmake[1]: Leaving directory `/home/guest/mozilla/obj-opt/accessible/src/base'


Reproducible: Always

Steps to Reproduce:
1.Build Mozilla Firefox Trunk build on AIX with Gnome RPMS of 64 bit
version.
2.
3.
Actual Results:  
Build fails with the above error.


Expected Results:  
No build failure

Comment 1

[Shailen]

Attachment: Patch V 1

Modified the code to include the header file "nsIDOMNode.h" in nsAccessibleTreeWalker.h file to fix the compilation error.

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

This never landed, setting back to UNCONFIRMED.

Comment 3

[alexander :surkov (:asurkov)]

Could anybody confirm the bug?

Comment 4

[Ginn Chen]

I've no idea.

But nsAccessibleTreeWalker.cpp includes nsAccessNode.h,
nsAccessNode.h includes nsCoreUtils.h,
nsCoreUtils.h includes nsIDOMNode.h

I don't know why it produces this error, and why the patch can fix it.

Comment 5

[alexander :surkov (:asurkov)]

worksforme?

Comment 6

[Ginn Chen]

WFM for now.

Shallen, please add a comment if you don't agree.

Comment 7

[Shailen]

I do not agree because,

When I compile on AIX, it gives me the error - 

"../../../dist/include/xpcom/nsCOMPtr.h", line 187.30: 1540-0408 (S) The base
class "nsIDOMNode" is declared but not defined.
"../../../dist/include/xpcom/nsCOMPtr.h", line 187.7: 1540-0700 (I) The
previous message was produced while processing "class
nsDerivedSafe<nsIDOMNode>".

The patch posted above does fix the compilation error.

Requesting to land the same.

Thanks,
Shailendra

Comment 8

[Ginn Chen]

Perhaps the sequence is a matter for your compiler.

Nit: Put nsIDOMNode.h above nsIDOMNodeList.h.

Will land when the tree turns green.

Comment 9

[Shailen]

Attachment: Patch V 2

Placed nsIDOMNode.h above nsIDOMNodeList.h.

Comment 10

[Marco Zehe (:MarcoZ)]

Pushed on Shailen's behalf in changeset:
http://hg.mozilla.org/mozilla-central/rev/ae4292c3c6ac
Thanks for the patch!

Comment 11

[Shailen]

I still do not see this patch in the latest trunk build.

Comment 12

[Nick Thomas [:nthomas] (UTC+12)]

http://hg.mozilla.org/mozilla-central/annotate/ae4292c3c6ac/accessible/src/base/nsAccessibleTreeWalker.h#l48

Comment 13

[Nick Thomas [:nthomas] (UTC+12)]

Note that trunk no longer means CVS HEAD (or Fx3.0) in common usage, it means the mozilla-central repository (whatever comes after 3.5).

Comment 14

[Shailen]

The tinderbox build that I download shows the version as 3.0.11pre

Can you please let me know when the mozilla-central repository changes be available for tinderbox builds ?