486912 - Undo/redo multi-line change case is severely broken

Status: RESOLVED FIXED

(Skywriter Graveyard :: Editor, defect, P4)

Description

[Gordon P. Hemsley [:GPHemsley]]

(Just popping this out into a new bug so I can close bug 485936.)

The undo/redo actions for the recent change case feature is severely broken. Attempting to use it will result in lost text and incorrect syntax highlighting.

Comment 1

[Sean Burke]

Attachment: Fix for undo

The issue was due to me using insertCharacters instead of insertChunk. For some reason the insertCharacters function does not like new line characters.

Comment 2

[Dion Almaer]

Hi Sean,

This bundle conflicts with Gordon's model/tab work for me. Are you tweaking some of the core there? Or did you just change your insertChunk calls to insertCharacters?

Cheers,

Dion

Comment 3

[Sean Burke]

- Thanks to Gordon for helping me correctly connect to undo/redo
- This changes the system to run off lc/uc commands instead of just key binds. 
- The keys are now CMD SHIFT L/U 

Please pull the changes from: http://bitbucket.org/sean111/bespinwork/
*PLEASE BE CAREFUL I MAY HAVE FUBARED A MERGE* 
if I did please let me know so I can attempt to fix it.

Comment 4

[Dion Almaer]

Hi Sean,

There is something weird happening here. Entire files are being replaced. It looks as though it is a formatting thing... do you use an editor with tabs turned on or something?

Comment 5

[Sean Burke]

No, I think one of the merges didn't correctly merge :/. I will double check my editor but I usually have it set to add spaces instead of tabs. I will see what I can do to clean it up.

Comment 6

[Sean Burke]

I think that my repo may be fixed now if not please let me know and I will make a bundle off a new one.

Comment 7

[Gordon P. Hemsley [:GPHemsley]]

When every line in a file gets replaced, that's usually an indicator that a line-ending change occurred. I've seen this happen a lot, and that is indeed what happened in Sean's changeset 5f6af42ac9a2. Those three files now have Windows line-endings (CRLF) instead of UNIX line-endings (LF).

Comment 8

[Sean Burke]

Bug is waiting for Gordon. Currently he is having an issue that I am unable to reproduce under a similar environment. Just wanted to update the ticket for anyone following the progress.

Comment 9

[Gordon P. Hemsley [:GPHemsley]]

This is a mass migration from Mozilla Labs :: Bespin to Bespin :: Editor.

Comment 10

[Gordon P. Hemsley [:GPHemsley]]

I think we got this all sorted out at some point, possibly changeset 5f6af42ac9a2. If not, open a new bug with more specific details.

Marking as RESOLVED FIXED.