Closed Bug 486939 Opened 15 years ago Closed 9 years ago

merge folding should only fold merges of >5 changesets

Categories

(Developer Services :: Mercurial: hg.mozilla.org, defect)

Product:
Developer Services
Component:
Mercurial: hg.mozilla.org
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: ted, Assigned: sid)

References

Details

(Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1487] )

Attachments

(1 file)

Patch for hgpoller to only fold merges of >5 changesets
1012 bytes, patch
Details | Diff | Splinter Review 
In bug 445560 comment 1, I said that we should only be hiding merges if they have >5 changesets, so that for the (fairly common) case of "push one changeset+a merge instead of rebasing" we don't hide the useful changeset. Apparently we missed that in the implementation though.
I'll take up this bug
Assignee: nobody → sid
Please go to the following link for more details: 

http://blog.sidkalra.com/2009/04/v10-release-completev10-release-complete/
Attachment #374464 - Flags: review?(ted.mielczarek)
Ted, looking at your review queue, these patches go back a while.  Do you have review comments that haven't been addressed in order for you to r+?  If not, are you planning to review?  And, if you don't think we should take these, can you r-?  

If there are comments that have yet to be addressed, does it make sense to clear these requests and ask for another request after the comments have been addressed?
Comment on attachment 374464 [details] [diff] [review]
Patch for hgpoller to only fold merges of >5 changesets

Clearing old review requests. We can revisit these at a later date.
Attachment #374464 - Flags: review?(ted.mielczarek)
Product: mozilla.org → Release Engineering
Product: Release Engineering → Developer Services
Whiteboard: [kanban:engops:https://kanbanize.com/ctrl_board/6/59]
Whiteboard: [kanban:engops:https://kanbanize.com/ctrl_board/6/59] → [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1469] [kanban:engops:https://kanbanize.com/ctrl_board/6/59]
Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1469] [kanban:engops:https://kanbanize.com/ctrl_board/6/59] → [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1473] [kanban:engops:https://kanbanize.com/ctrl_board/6/59]
Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1473] [kanban:engops:https://kanbanize.com/ctrl_board/6/59] → [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1479] [kanban:engops:https://kanbanize.com/ctrl_board/6/59]
Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1479] [kanban:engops:https://kanbanize.com/ctrl_board/6/59] → [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1481] [kanban:engops:https://kanbanize.com/ctrl_board/6/59]
Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1481] [kanban:engops:https://kanbanize.com/ctrl_board/6/59] → [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1487] [kanban:engops:https://kanbanize.com/ctrl_board/6/59]
Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1487] [kanban:engops:https://kanbanize.com/ctrl_board/6/59] → [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1487]
I'm going to say nobody cares about this (assuming it is still a problem - a lot of this code has changed over the years and this may no longer be an issue).
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.