merge folding should only fold merges of >5 changesets

RESOLVED WONTFIX

Status

Developer Services
Mercurial: hg.mozilla.org
RESOLVED WONTFIX
8 years ago
2 years ago

People

(Reporter: ted, Assigned: Sid Kalra)

Tracking

Details

(Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1487] )

Attachments

(1 attachment)

(Reporter)

Description

8 years ago
In bug 445560 comment 1, I said that we should only be hiding merges if they have >5 changesets, so that for the (fairly common) case of "push one changeset+a merge instead of rebasing" we don't hide the useful changeset. Apparently we missed that in the implementation though.
(Assignee)

Comment 1

8 years ago
I'll take up this bug
Assignee: nobody → sid
(Assignee)

Comment 2

8 years ago
Created attachment 374464 [details] [diff] [review]
Patch for hgpoller to only fold merges of >5 changesets

Please go to the following link for more details: 

http://blog.sidkalra.com/2009/04/v10-release-completev10-release-complete/
Attachment #374464 - Flags: review?(ted.mielczarek)
Ted, looking at your review queue, these patches go back a while.  Do you have review comments that haven't been addressed in order for you to r+?  If not, are you planning to review?  And, if you don't think we should take these, can you r-?  

If there are comments that have yet to be addressed, does it make sense to clear these requests and ask for another request after the comments have been addressed?
(Reporter)

Comment 4

7 years ago
Comment on attachment 374464 [details] [diff] [review]
Patch for hgpoller to only fold merges of >5 changesets

Clearing old review requests. We can revisit these at a later date.
Attachment #374464 - Flags: review?(ted.mielczarek)
Product: mozilla.org → Release Engineering
Product: Release Engineering → Developer Services

Updated

3 years ago
Whiteboard: [kanban:engops:https://kanbanize.com/ctrl_board/6/59]

Updated

3 years ago
Whiteboard: [kanban:engops:https://kanbanize.com/ctrl_board/6/59] → [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1469] [kanban:engops:https://kanbanize.com/ctrl_board/6/59]

Updated

3 years ago
Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1469] [kanban:engops:https://kanbanize.com/ctrl_board/6/59] → [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1473] [kanban:engops:https://kanbanize.com/ctrl_board/6/59]

Updated

3 years ago
Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1473] [kanban:engops:https://kanbanize.com/ctrl_board/6/59] → [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1479] [kanban:engops:https://kanbanize.com/ctrl_board/6/59]

Updated

3 years ago
Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1479] [kanban:engops:https://kanbanize.com/ctrl_board/6/59] → [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1481] [kanban:engops:https://kanbanize.com/ctrl_board/6/59]

Updated

3 years ago
Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1481] [kanban:engops:https://kanbanize.com/ctrl_board/6/59] → [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1487] [kanban:engops:https://kanbanize.com/ctrl_board/6/59]
Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1487] [kanban:engops:https://kanbanize.com/ctrl_board/6/59] → [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1487]

Comment 5

2 years ago
I'm going to say nobody cares about this (assuming it is still a problem - a lot of this code has changed over the years and this may no longer be an issue).
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.