Identity Settings dialog has shrunk

RESOLVED FIXED in Thunderbird 3.0b4

Status

defect
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: u60234, Assigned: mkmelin)

Tracking

({fixed-seamonkey2.0, regression})

Dependency tree / graph
Bug Flags:
blocking-thunderbird3 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments)

Reporter

Description

10 years ago
Posted image screenshot
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b4pre) Gecko/20090405 Shredder/3.0b3pre

The Identity Settings dialog has become too small for its content.

Steps to reproduce:
1. Open Account Settings and select an account.
2. Click on "Manage Identities..." button.
3. Select an identity and click "Edit" to open the Identity Settings dialog.
4. Select the "Composition & Addressing" tab.

Result:
The dropdown for where to place my signature is cut off.

This is a regression between BuildID=20090319044410 and BuildID=20090320034500. Backing out bug 390734 fixes this bug.
Flags: blocking-thunderbird3?
Flags: blocking-thunderbird3? → blocking-thunderbird3+
Whiteboard: [no l10n impact]
I've just taken a look at this. The identity settings dialog currently has a hard-coded with of 40em:

http://mxr.mozilla.org/comm-central/source/mailnews/base/prefs/content/am-identities-list.xul#44

Probably the best way to fix this is in a similar manner to the preferences dialog and using localised style values per-platform:

http://mxr.mozilla.org/comm-central/source/mail/components/preferences/preferences.xul#69

then localisations can alter the width if necessary as well and we can tweak it per platform (i.e. it looks just fine on Mac with 40em).

Any takers? (TB 3b4 blocking).
Whiteboard: [no l10n impact] → [has l10n impact][has proposed solution]
Target Milestone: --- → Thunderbird 3.0b4
(In reply to comment #1)
> (i.e. it looks just fine on Mac with 40em).
I thought Mac used bold fonts by default, which tends to need a wider dialog.

It is possible to do without the width style if you add width="1" to all <description>&...;</description> tags. The dialog will then size to fit.
(Note: don't forget S/MIME!) This may result in a large dialog if the user has long account or smtp server names.
Assignee

Comment 3

10 years ago
Posted patch proposed fixSplinter Review
Interestingly, on linux is actually 40em, although it's set to be 35em - so it adjusts automatically for the would-be overflow.

Given sm is already string frozen, maybe we'll just make this hardcoded 40em too - i don't remember localizers complaining earlier. I'd also hope all platforms can use the same value here, if we need to i don't think it would hurt much to add a few ems in width.

I recalled the identity edit pops up at 0,0 on windows, so i fixed that too.

If we want to use ch instead, 40em was 67ch for me.
Assignee: nobody → mkmelin+mozilla
Status: NEW → ASSIGNED
Attachment #397886 - Flags: superreview?(neil)
Attachment #397886 - Flags: review?(bugzilla)
Assignee

Updated

10 years ago
Whiteboard: [has l10n impact][has proposed solution] → [no l10n impact]
Whiteboard: [no l10n impact] → [no l10n impact][has patch, needs review]
Comment on attachment 397886 [details] [diff] [review]
proposed fix

Unforunately this has the side effect of making the identity dialog resizable on mac.

The SeaMonkey string freeze ends today and starts again on the 6th Oct. I've not seen evidence of locales wanting to change the width of the dialog but that doesn't mean they haven't realised they could ask to change it ;-)
Attachment #397886 - Flags: review?(bugzilla) → review-
Posted image another screenshot
(In reply to comment #4)
The bug reporter is a Swedish localizer ;)
Adding another screenshot showing how badly we need to get this fixed.

Mozilla/5.0 (Windows; U; Windows NT 6.0; sk; rv:1.9.1.4pre) Gecko/20090903 Shredder/3.0b4pre
Comment on attachment 397886 [details] [diff] [review]
proposed fix

I like 67ch :-)

>+  window.openDialog("am-identity-edit.xul", "", "chrome,modal,centerscreen", args);
Sadly at least in Suite the identity list dialog itself still opens at 0, 0 :-(
Attachment #397886 - Flags: superreview?(neil) → superreview+
Assignee

Comment 7

10 years ago
(In reply to comment #4)
> (From update of attachment 397886 [details] [diff] [review])
> Unforunately this has the side effect of making the identity dialog resizable
> on mac.

I'm confused. In bug 507392 comment 17 you said that on mac, titlebar makes dialogs resizable. Here i'm *removing* the (as i figured redundant) titlebar param, and that makes it resizable?
(In reply to comment #7)
> (In reply to comment #4)
> > (From update of attachment 397886 [details] [diff] [review])
> > Unforunately this has the side effect of making the identity dialog resizable
> > on mac.
> I'm confused. In bug 507392 comment 17 you said that on mac, titlebar makes
> dialogs resizable. Here i'm *removing* the (as i figured redundant) titlebar
> param, and that makes it resizable?
He actually said "titlebar" and "resizable" makes dialogs NOT resizable. As per my bug 507392 comment #22, this isn't quite true; "resizable" and "resizable=yes" don't work, while "titlebar" and "resizable=no" do.
Assignee

Comment 9

10 years ago
Ah yes. Just confused then;)
Assignee

Comment 10

10 years ago
Carrying fwd sr=neil
(The identity-list it self should now also be centerscreened.)
Attachment #398680 - Flags: superreview+
Attachment #398680 - Flags: review?(bugzilla)
Assignee

Updated

10 years ago
Whiteboard: [no l10n impact][has patch, needs review] → [has l10n impact][has patch, needs review]
Comment on attachment 398680 [details] [diff] [review]
proposed fix, v2

That's better, thanks.

r=Standard8
Attachment #398680 - Flags: review?(bugzilla) → review+
Whiteboard: [has l10n impact][has patch, needs review] → [has l10n impact][ready to land]
Assignee

Comment 12

10 years ago
changeset:   3546:37532e529fbe
http://hg.mozilla.org/comm-central/rev/37532e529fbe

->FIXED
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Whiteboard: [has l10n impact][ready to land]
Assignee

Updated

10 years ago
OS: Windows XP → All
Hardware: x86 → All
You need to log in before you can comment on or make changes to this bug.