486991 - Use TimeStamp/TimeDuration instead of PRIntervalTime in content/media

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

PRIntervalTime can wrap around and does not provide typechecking to distinguish "moments" from "durations".

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: Part 1: update TimeStamp/TimeDuration

Turns out some of those extra operators are needed sooner than I thought.

I've used a trick to allow TimeDuration(0) to compile but not, say, TimeDuration(3). When doing conversion work I found TimeDuration(0) much more readable than TimeDuration(). Obviously when the parameter is 0 there is no issue with what the units are.

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: Part 2: convert nsMediaCache to use TimeStamp/TimeDuration

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: Part 3: convert media decoders and nsMediaStream to use TimeStamp/TimeDuration

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

http://hg.mozilla.org/mozilla-central/rev/2ef288cba538
http://hg.mozilla.org/mozilla-central/rev/9636c809be78
http://hg.mozilla.org/mozilla-central/rev/e002cdfb86c1

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 371195 [details] [diff] [review]
Part 1: update TimeStamp/TimeDuration

We'll need this in 1.9.1 to avoid potential bugs when PRIntervalTime wraps around

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 371195 [details] [diff] [review]
Part 1: update TimeStamp/TimeDuration

a191=beltzner

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/fcb135f5d833
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/f2ad6aa56a6b
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/9d5b91a57fef