Use TimeStamp/TimeDuration instead of PRIntervalTime in content/media

RESOLVED FIXED

Status

()

RESOLVED FIXED
10 years ago
9 years ago

People

(Reporter: roc, Assigned: roc)

Tracking

({fixed1.9.1})

Trunk
fixed1.9.1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

PRIntervalTime can wrap around and does not provide typechecking to distinguish "moments" from "durations".
Assignee: nobody → roc
Created attachment 371195 [details] [diff] [review]
Part 1: update TimeStamp/TimeDuration

Turns out some of those extra operators are needed sooner than I thought.

I've used a trick to allow TimeDuration(0) to compile but not, say, TimeDuration(3). When doing conversion work I found TimeDuration(0) much more readable than TimeDuration(). Obviously when the parameter is 0 there is no issue with what the units are.
Attachment #371195 - Flags: review?
Attachment #371195 - Flags: review? → review?(benjamin)
Created attachment 371196 [details] [diff] [review]
Part 2: convert nsMediaCache to use TimeStamp/TimeDuration
Attachment #371196 - Flags: review?(chris.double)
Created attachment 371197 [details] [diff] [review]
Part 3: convert media decoders and nsMediaStream to use TimeStamp/TimeDuration
Attachment #371197 - Flags: review?(chris.double)
Attachment #371197 - Attachment description: Convert media decoders and nsMediaStream to use TimeStamp/TimeDuration → Part 3: convert media decoders and nsMediaStream to use TimeStamp/TimeDuration

Updated

10 years ago
Attachment #371196 - Flags: review?(chris.double) → review+

Updated

10 years ago
Attachment #371197 - Flags: review?(chris.double) → review+

Updated

10 years ago
Attachment #371195 - Flags: review?(benjamin) → review+
Comment on attachment 371195 [details] [diff] [review]
Part 1: update TimeStamp/TimeDuration

We'll need this in 1.9.1 to avoid potential bugs when PRIntervalTime wraps around
Attachment #371195 - Flags: approval1.9.1?
Whiteboard: [needs 191 landing] → [needs 191 approval]
Attachment #371195 - Flags: approval1.9.1? → approval1.9.1+
Comment on attachment 371195 [details] [diff] [review]
Part 1: update TimeStamp/TimeDuration

a191=beltzner
Whiteboard: [needs 191 approval] → [needs 191 landing]
You need to log in before you can comment on or make changes to this bug.