487014 - Inactive addons can still be installed from the versions page

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect, P2)

Description

[tstststst]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.9.0.8) Gecko/2009032609 Firefox/3.0.8
Build Identifier: 

Addons which are marked inactive using the new developer tools, can still be accessed and installed from their versions page

Reproducible: Always

Steps to Reproduce:
1. Upload addon
2. Make addon inactive via new developer tools
3. Go to versions page of addon
Actual Results:  
Addon is displayed and acessible

Expected Results:  
Addon should not be displayed, should not be installable

Comment 1

[Fred Wenzel [:wenzel]]

Do you have an example add-on this is happening for?

Comment 2

[tstststst]

I've deleted my own addon in the meantime, but it works with any deactivated addon:

for example
https://addons.mozilla.org/en-US/firefox/addon/11321 -> not found
https://addons.mozilla.org/en-US/firefox/addons/versions/11321 -> can be installed

(works also for 11320 and so on, you just have to find any deactivated addon)

Comment 3

[Fred Wenzel [:wenzel]]

Yes, I can confirm this. Thanks for the good catch! I'll fix it.

Comment 4

[Fred Wenzel [:wenzel]]

Attachment: Patch, rev. 1

Good Friday patch goodness.

Comment 5

[Wil Clouser [:clouserw]]

Comment on attachment 372029 [details] [diff] [review]
Patch, rev. 1

Test case plz. :)

Comment 6

[Fred Wenzel [:wenzel]]

(In reply to comment #5)
> Test case plz. :)

Do you still need one? Comment 2 has one, though that may not be part of your DB snapshot yet if it's older. Otherwise, any "inactive=1" add-on will do.

Comment 7

[Wil Clouser [:clouserw]]

I mean a unit test.  Not sure we have a disabled add-on in the test data - might have to add one.

Comment 8

[Fred Wenzel [:wenzel]]

Attachment: Testcase

There you go.

Comment 9

[Wil Clouser [:clouserw]]

Comment on attachment 372604 [details] [diff] [review]
Testcase

thanks

Comment 10

[Fred Wenzel [:wenzel]]

r24484 (code) and r24485 (test), thanks.

Comment 11

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; I deleted files from my test add-on (9331), and then tried to access its all-versions page:

https://preview.addons.mozilla.org/en-US/firefox/addons/versions/9331

Got "Add-on not found!"