Closed
Bug 487019
Opened 15 years ago
Closed 15 years ago
Rename IsDependentAttribute to AttributeDefinesGeometry
Categories
(Core :: SVG, defect)
Core
SVG
Tracking
()
RESOLVED
FIXED
People
(Reporter: jwatt, Unassigned)
Details
Attachments
(1 file)
|
5.56 KB,
patch
|
longsonr
:
review+
|
Details | Diff | Splinter Review |
The name "IsDependentAttribute" is a really poor name. We should rename it to AttributeDefinesGeometry.
Attachment #371216 -
Flags: review?(longsonr)
|
||
Comment 1•15 years ago
|
||
Comment on attachment 371216 [details] [diff] [review] patch Nothing wrong with this although I would have awarded bonus points for using const nsIAtom *aName
Attachment #371216 -
Flags: review?(longsonr) → review+
|
Reporter | |
Comment 2•15 years ago
|
||
Yeah, good point. I made that change for checkin. Pushed http://hg.mozilla.org/mozilla-central/rev/0d93e8dbf91a
Flags: in-testsuite-
|
|
Reporter | |
Updated•15 years ago
|
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•