Closed Bug 487030 Opened 16 years ago Closed 16 years ago

Linux 64 build errors

Categories

(Tamarin Graveyard :: Baseline JIT (CodegenLIR), defect)

Product:
Tamarin Graveyard
Component:
Baseline JIT (CodegenLIR)
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: treilly, Assigned: stejohns)

Details

Attachments

(1 file)

Patch
29.90 KB, patch
treilly
: review+
Details | Diff | Splinter Review
Fix compile warnings and make our linux64 build settings match the players. /home/flplbldr/Builds/FlashRuntimeChangelistLinux64/20090404.m.155/FlashRuntimeCompileLog.txt,Line: 596 /home/flplbldr/Builds/FlashRuntimeChangelistLinux64/20090404.m.155/FlashRuntime/Main/code/third_party/avmplus/core/CodegenLIR.cpp:2751: error: suggest parentheses around && within || /home/flplbldr/Builds/FlashRuntimeChangelistLinux64/20090404.m.155/FlashRuntimeCompileLog.txt,Line: 598 /home/flplbldr/Builds/FlashRuntimeChangelistLinux64/20090404.m.155/FlashRuntime/Main/code/third_party/avmplus/core/CodegenLIR.cpp:4824: error: suggest parentheses around && within || /home/flplbldr/Builds/FlashRuntimeChangelistLinux64/20090404.m.155/FlashRuntimeCompileLog.txt,Line: 600 /home/flplbldr/Builds/FlashRuntimeChangelistLinux64/20090404.m.155/FlashRuntime/Main/code/third_party/avmplus/core/CodegenLIR.cpp:5249: error: suggest parentheses around && within || /home/flplbldr/Builds/FlashRuntimeChangelistLinux64/20090404.m.155/FlashRuntimeCompileLog.txt,Line: 608 /home/flplbldr/Builds/FlashRuntimeChangelistLinux64/20090404.m.155/FlashRuntime/Main/code/third_party/avmplus/nanojit/NativeX64.cpp:126: error: suggest parentheses around arithmetic in operand of | /home/flplbldr/Builds/FlashRuntimeChangelistLinux64/20090404.m.155/FlashRuntimeCompileLog.txt,Line: 610 /home/flplbldr/Builds/FlashRuntimeChangelistLinux64/20090404.m.155/FlashRuntime/Main/code/third_party/avmplus/nanojit/NativeX64.cpp:134: error: suggest parentheses around arithmetic in operand of | /home/flplbldr/Builds/FlashRuntimeChangelistLinux64/20090404.m.155/FlashRuntimeCompileLog.txt,Line: 611 /home/flplbldr/Builds/FlashRuntimeChangelistLinux64/20090404.m.155/FlashRuntime/Main/code/third_party/avmplus/nanojit/NativeX64.cpp:135: error: suggest parentheses around arithmetic in operand of | /home/flplbldr/Builds/FlashRuntimeChangelistLinux64/20090404.m.155/FlashRuntimeCompileLog.txt,Line: 613 /home/flplbldr/Builds/FlashRuntimeChangelistLinux64/20090404.m.155/FlashRuntime/Main/code/third_party/avmplus/nanojit/NativeX64.cpp:142: error: suggest parentheses around arithmetic in operand of | /home/flplbldr/Builds/FlashRuntimeChangelistLinux64/20090404.m.155/FlashRuntimeCompileLog.txt,Line: 615 /home/flplbldr/Builds/FlashRuntimeChangelistLinux64/20090404.m.155/FlashRuntime/Main/code/third_party/avmplus/nanojit/NativeX64.cpp:348: error: suggest parentheses around && within ||
Assignee: nobody → rreitmai
we need to make tamarin's warning settings at least the same or a superset of flash's in this case, in addition to fixing the warnings.
I think this is -Wparentheses in gcc. I doubt there's a similar flag for VisualStudio, alas.
Assignee: rreitmai → stejohns
Attached patch Patch — — Splinter Review
crank up the warning levels for GCC builds, to better approximate the warnings that Flash and AIR have enabled. Then, fix those warnings. Note: when building on GCC 4.3 or later we now enable warnings-as-errors, as that version of gcc has added a way to disable the "clobbered" warning we've been living with.
Attachment #371328 - Flags: review?(treilly)
Attachment #371328 - Flags: review?(treilly) → review+
pushed to redux as changeset: 1690:6eae9388a11d
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: