487035 - bit field too small

Status: VERIFIED FIXED

(Tamarin Graveyard :: Virtual Machine, defect)

Description

[Tom Donovan]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US) AppleWebKit/525.19 (KHTML, like Gecko) Chrome/1.0.154.53 Safari/525.19
Build Identifier: tamarin-central 97a40064f87a 2009-03-27 15:16 -0700

The 2-bit 'pushes' bitfield in struct WordOpcodeAttr in core/wopcodes.h is too small for some of the op codes in core/wopcodes.cpp:  get4locals and get5locals.

'pushes' does not appear to be used anywhere, but this causes a truncation warning with gcc 4.3.3+.

Reproducible: Always

Steps to Reproduce:
1. Build tamarin with gcc 4.3.3+

Actual Results:  
~/tamarin-central/core/wopcodes.cpp:405: warning: large integer implicitly truncated to unsigned type

Expected Results:  
no warning

Comment 1

[Tom Donovan]

Attachment: proposed patch

Comment 2

[Lars T Hansen]

The patch is good.  Do you have commit privileges or do you need me to push it?

(I believe pushes is used by an experimental optimization framework, see bug 460000.  But that framework does not operate on instructions emitted by the peephole optimizer so it was probably not affected by this bug.)

Comment 3

[Tom Donovan]

Wow!  A 12-minute response - you guys are quick...
No commit privs - so please push the patch Lars.
-tom-

Comment 4

[Lars T Hansen]

redux changeset:   1678:51ad5721747d