Status

Tamarin
Virtual Machine
--
minor
VERIFIED FIXED
9 years ago
9 years ago

People

(Reporter: Tom Donovan, Unassigned)

Tracking

Details

Attachments

(1 attachment)

(Reporter)

Description

9 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US) AppleWebKit/525.19 (KHTML, like Gecko) Chrome/1.0.154.53 Safari/525.19
Build Identifier: tamarin-central 97a40064f87a 2009-03-27 15:16 -0700

The 2-bit 'pushes' bitfield in struct WordOpcodeAttr in core/wopcodes.h is too small for some of the op codes in core/wopcodes.cpp:  get4locals and get5locals.

'pushes' does not appear to be used anywhere, but this causes a truncation warning with gcc 4.3.3+.

Reproducible: Always

Steps to Reproduce:
1. Build tamarin with gcc 4.3.3+

Actual Results:  
~/tamarin-central/core/wopcodes.cpp:405: warning: large integer implicitly truncated to unsigned type

Expected Results:  
no warning
(Reporter)

Comment 1

9 years ago
Created attachment 371238 [details] [diff] [review]
proposed patch

Comment 2

9 years ago
The patch is good.  Do you have commit privileges or do you need me to push it?

(I believe pushes is used by an experimental optimization framework, see bug 460000.  But that framework does not operate on instructions emitted by the peephole optimizer so it was probably not affected by this bug.)
(Reporter)

Comment 3

9 years ago
Wow!  A 12-minute response - you guys are quick...
No commit privs - so please push the patch Lars.
-tom-

Comment 4

9 years ago
redux changeset:   1678:51ad5721747d
Status: UNCONFIRMED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED

Updated

9 years ago
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.