487144 - Auto-publisher settings tweaks

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Collections, defect)

Description

[Justin Scott [:fligtar]]

Now that I have an auto-publisher setup, the fields to edit its properties are disabled. These should be enabled, and changes to the name and listed status should update using the API (https://wiki.mozilla.org/User:LesOrchard/BandwagonAPI#PUT_-_Update_collection_details)

Changes to the selected add-ontypes should update the published add-ons.

Additionally, please add a checkbox under the add-ontypes section that specifies whether all add-ons should be published or only enabled add-ons. The text should read "[x] Only publish enabled add-ons" and should be checked by default.

Comment 1

[David McNamara [:mackers]]

(In reply to comment #0)
> Changes to the selected add-ontypes should update the published add-ons.

So, if the user, say, deselects "dictionaries", all previously auto-published dictionaries should be removed from the auto publisher collection?

> Additionally, please add a checkbox under the add-ontypes section that
> specifies whether all add-ons should be published or only enabled add-ons. The
> text should read "[x] Only publish enabled add-ons" and should be checked by
> default.

Ok. Have done the UI. Implementation waiting for fix for bug 486126.

Brian, please assign this bug to me.

Comment 2

[Justin Scott [:fligtar]]

Moving to revised M5 milestone (4/28).

Comment 3

[David McNamara [:mackers]]

What remains in this bug:

1) Implement the "Update Auto-publisher" button in settings.

This should update the auto-publisher's name and listed status.

2) Implement conditional auto-publishing. 

Based on user's selection of add-on type and enabled/disabled.



Justin, what should the behaviour be if the user changes the add-on types or disabled/enabled checkboxes and then clicks "Update Auto-publisher" ?

Comment 4

[Justin Scott [:fligtar]]

Hmm, good question. We can't really expect the extension to know which add-ons to remove after an update. If we wipe the entire collection and start over, we lose the original publish dates and any comments the user entered via the website.

We might just have to say that settings changes will only take effect from now on, and that any retroactive changes have to be made manually through the website.

Thoughts?

Comment 5

[David McNamara [:mackers]]

(In reply to comment #4)
> We might just have to say that settings changes will only take effect from now
> on, and that any retroactive changes have to be made manually through the
> website.
> 
> Thoughts?

That seems reasonable to me. 

What exact text should we use? What form will the message take? An alert?

Comment 6

[Justin Scott [:fligtar]]

When the user clicks "Update Auto-publisher", a confirmation box should come up that says:

Your new settings will take effect immediately, but will not affect add-ons that have already been published.

[Cancel] [OK]

Comment 7

[David McNamara [:mackers]]

(In reply to comment #3)
> 2) Implement conditional auto-publishing. 
> 
> Based on user's selection of add-on type and enabled/disabled.

This has been completed.

r24637

Comment 8

[David McNamara [:mackers]]

(In reply to comment #3)
> 1) Implement the "Update Auto-publisher" button in settings.
> 
> This should update the auto-publisher's name and listed status.

This has also been completed.

r24639