Closed Bug 487154 Opened 17 years ago Closed 17 years ago

merge MMGC fixes from Flash to Redux

Categories

(Tamarin Graveyard :: Virtual Machine, defect)

Product:
Tamarin Graveyard
Component:
Virtual Machine
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: stejohns, Assigned: stejohns)

Details

Attachments

(1 file, 1 obsolete file)

Patch #2
13.29 KB, patch
treilly
: review-
Details | Diff | Splinter Review
Attached patch Patch (obsolete) — — Splinter Review
Grab bag of fixes made in Flash sourcebase that need to be merged to Redux. Tommy Reilly to provides detailed description.
Attachment #371356 - Flags: review?(treilly)
Attachment #371356 - Flags: review?(treilly) → review-
Comment on attachment 371356 [details] [diff] [review] Patch Looks good except for the ifndef DEBUGGER in cleanstack we can't do that since apollo always defined DEBUGGER
I'll resubmit without that change... what's the story on that part, if it's wrong we need to deal with it elsewhere.
Attached patch Patch #2 — — Splinter Review
rebased, and ifdef DEBUGGER removed from CleanStack, otherwise same as first patch
Attachment #371356 - Attachment is obsolete: true
Attachment #371495 - Flags: review?(treilly)
Comment on attachment 371495 [details] [diff] [review] Patch #2 sorry I think GCWeakRef.h is bogus too, a weak ref is GCObject so you should be able to call delete on it and it calls GC::Free. Next time we do a player merge lets fix that differently over there.
Attachment #371495 - Flags: review?(treilly) → review-
consider that a review+ w/o the GCWeakRef.h changes.
pushed to redux as changeset: 1710:3322931d6b7a
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Resolved fixed engineering / work item that has been pushed. Setting status to verified.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: