487179 - nsHashtable::Put is unsafe

Status: RESOLVED WORKSFORME

(Core :: XPCOM, defect)

Description

[timeless]

204 void *nsHashtable::Put(nsHashKey *aKey, void *aData)
206     void *res =  NULL;
215     HTEntry* entry =
216         static_cast<HTEntry*>
217                    (PL_DHashTableOperate(&mHashtable, aKey, PL_DHASH_ADD));
219     if (entry) {                // don't return early, or you'll be locked!
225             // new entry (leave res == null)
226             entry->key = aKey->Clone();
233     return res;

1. #217 PL_DHASH_ADD can fail, if it does, application logic won't know and will leak.
2. #226 Clone can fail, if it does, application logic won't know, and the item will not be found (this is essentially a leak). If anyone ever compares against such a node, it will crash in the Key::Equals method.

Comment 1

[Andrei Purice]

Hello,
Can you still reproduce this issue or should we close it?

Comment 2

[Andrew McCreight [:mccr8]]

nsHashtable does not exist, so I think we can close this.