DownloadScanner shouldn't be on the critical path in DownloadManager's getService

NEW
Unassigned

Status

()

--
enhancement
10 years ago
10 years ago

People

(Reporter: timeless, Unassigned)

Tracking

Trunk
x86
Windows XP
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

10 years ago
Created attachment 371405 [details]
analyze output

If at all possible, DownloadScanner should not be initialized from the main thread.

I know you have this wonderful comment talking about threadsafety, and i know that i'm working on improving the threadsafety story, but your code scared me because my browser got stuck in nsDownloadScanner::EnumerateOAVProviders for a while.

fwiw, I have Symantec Client Security, and this is an Opt build of my own (w/ a bunch of patches, but none to download manager....)
You are running XP w/o SP2 I take it? Otherwise we would be using IAE. I am very surprised that enumeration is taking so long because AFAIK, it is just enumerating through a particular key in the registry. Can you tell me exactly what function inside EnumerateOAVProviders is taking a while?
You need to log in before you can comment on or make changes to this bug.