487185 - External links open multiple times

Status: RESOLVED FIXED

(Mozilla Labs :: Prism, defect)

Description

[Matthew Gertner]

Sometimes in Gmail, clicking on an external link causes it to open multiple times in the default browser. It seems like the longer I use Gmail, the more tabs open when I click a link.

Comment 1

[Matthew Gertner]

Attachment: Remove old event listeners (in any) for clicks before adding new ones

Comment 2

[Matthew Gertner]

Comment on attachment 371408 [details] [diff] [review]
Remove old event listeners (in any) for clicks before adding new ones

Oops, just had the problem again. Will have to keep looking for the solution.

Comment 4

[Matthew Gertner]

Comment on attachment 371408 [details] [diff] [review]
Remove old event listeners (in any) for clicks before adding new ones

I'm continuing to use this patch, and it seems to help a lot even if it doesn't fix the problem entirely. Let's get it checked in and take it from there.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 371408 [details] [diff] [review]
Remove old event listeners (in any) for clicks before adding new ones

This really can't help as is. the removeEventListener call uses the function arg to lookup and remove the event handler.

In this case you are using anonymous functions for both add and remove, so it's not possible to remove any listeners.

Comment 6

[Matthew Gertner]

(In reply to comment #5)
> (From update of attachment 371408 [details] [diff] [review])
> This really can't help as is. the removeEventListener call uses the function
> arg to lookup and remove the event handler.
> 
> In this case you are using anonymous functions for both add and remove, so it's
> not possible to remove any listeners.

D'oh! I guess it's just coincidence that I am seeing the problem less often. I'll fix it.

Comment 7

[Matthew Gertner]

Attachment: Used named functions for click handlers

Something like this?

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 374333 [details] [diff] [review]
Used named functions for click handlers

Yeah, something like that should work. You have HostUI removal cruft in here too!