Closed
Bug 487192
Opened 15 years ago
Closed 15 years ago
Move both copies (one is char, the other is PRUnichar) of nsWildCard into xpcom
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
People
(Reporter: jag+mozilla, Assigned: jag+mozilla)
Details
Attachments
(4 files)
8.91 KB,
patch
|
benjamin
:
review+
benjamin
:
superreview+
|
Details | Diff | Splinter Review |
12.10 KB,
patch
|
benjamin
:
review+
benjamin
:
superreview+
|
Details | Diff | Splinter Review |
18.84 KB,
patch
|
benjamin
:
review+
benjamin
:
superreview+
|
Details | Diff | Splinter Review |
9.39 KB,
patch
|
benjamin
:
review+
benjamin
:
superreview+
|
Details | Diff | Splinter Review |
We've got two copies of nsWildCard.{h,cpp}, one for |char*| and one for |PRUnichar*|. Some fixes and license changes were only applied to the |char*| version, and I'd like to address that by using template functions for the implementation code (wrapped inside / hidden by the publicly visible functions) so any future fixes only need to be made once, and I'd like to move the result into xpcom/io/ or some other suitable place.
Comment 1•15 years ago
|
||
See also bug 484353.
Assignee | ||
Comment 2•15 years ago
|
||
Assignee | ||
Updated•15 years ago
|
Attachment #372623 -
Attachment description: Step 1: Synch up filepicker's nsWildCard to fixes made to libjar's version. → Step 1: Sync up filepicker's nsWildCard to fixes made to libjar's version.
Assignee | ||
Comment 3•15 years ago
|
||
Assignee | ||
Comment 4•15 years ago
|
||
Assignee | ||
Comment 5•15 years ago
|
||
Assignee | ||
Updated•15 years ago
|
Attachment #372623 -
Flags: superreview?(benjamin)
Attachment #372623 -
Flags: review?(ted.mielczarek)
Assignee | ||
Updated•15 years ago
|
Attachment #372624 -
Flags: superreview?(benjamin)
Attachment #372624 -
Flags: review?(ted.mielczarek)
Assignee | ||
Updated•15 years ago
|
Attachment #372625 -
Flags: superreview?(benjamin)
Attachment #372625 -
Flags: review?(ted.mielczarek)
Assignee | ||
Updated•15 years ago
|
Attachment #372626 -
Flags: superreview?(benjamin)
Attachment #372626 -
Flags: review?(ted.mielczarek)
Comment 6•15 years ago
|
||
You know I'm not actually an XPCOM peer, right?
Assignee | ||
Comment 7•15 years ago
|
||
Hrm.
Assignee | ||
Updated•15 years ago
|
Attachment #372623 -
Flags: review?(ted.mielczarek) → review?(shaver)
Assignee | ||
Updated•15 years ago
|
Attachment #372624 -
Flags: review?(ted.mielczarek) → review?(shaver)
Assignee | ||
Updated•15 years ago
|
Attachment #372625 -
Flags: review?(ted.mielczarek) → review?(shaver)
Assignee | ||
Updated•15 years ago
|
Attachment #372626 -
Flags: review?(ted.mielczarek) → review?(shaver)
Updated•15 years ago
|
Attachment #372623 -
Flags: superreview?(benjamin)
Attachment #372623 -
Flags: superreview+
Attachment #372623 -
Flags: review?(shaver)
Attachment #372623 -
Flags: review+
Updated•15 years ago
|
Attachment #372624 -
Flags: superreview?(benjamin)
Attachment #372624 -
Flags: superreview+
Attachment #372624 -
Flags: review?(shaver)
Attachment #372624 -
Flags: review+
Updated•15 years ago
|
Attachment #372625 -
Flags: superreview?(benjamin)
Attachment #372625 -
Flags: superreview+
Attachment #372625 -
Flags: review?(shaver)
Attachment #372625 -
Flags: review+
Updated•15 years ago
|
Attachment #372626 -
Flags: superreview?(benjamin)
Attachment #372626 -
Flags: superreview+
Attachment #372626 -
Flags: review?(shaver)
Attachment #372626 -
Flags: review+
Assignee | ||
Comment 8•15 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/3251f66498f9 http://hg.mozilla.org/mozilla-central/rev/4f0c78fb34fc http://hg.mozilla.org/mozilla-central/rev/d1f45c237fc4 http://hg.mozilla.org/mozilla-central/rev/5eeacfad0e2b
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 9•15 years ago
|
||
Bustage fix: http://hg.mozilla.org/mozilla-central/rev/4e91deae75dc
Comment 10•15 years ago
|
||
Regression: DHTML increase 1.43% on XP Firefox http://graphs-new.mozilla.org/graph.html#tests=[{%22machine%22:55,%22test%22:18,%22branch%22:1},{%22machine%22:56,%22test%22:18,%22branch%22:1},{%22machine%22:57,%22test%22:18,%22branch%22:1},{%22machine%22:71,%22test%22:18,%22branch%22:1}]&sel=1242197940,1242370740 Previous results: 1073.91 from build 20090513234400 of revision 5eeacfad0e2b at 2009-05-13 23:44:00 on qm-pxp-fast03 run # 0 New results: 1089.29 from build 20090513235938 of revision 4e91deae75dc at 2009-05-13 23:59:00 on qm-pxp-trunk03 run # 0 Suspected checkin range: from revision 5eeacfad0e2b to revision 4e91deae75dc http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=5eeacfad0e2b&tochange=4e91deae75dc ... implicates this patch
Assignee | ||
Comment 11•15 years ago
|
||
Highly unlikely that these changes affected DHTML. Also, have you seen the graphs you linked to? 1) They've been steadily increasing over the past day. 2) There's a big dip around the time you quote. I'm not sure what caused the dip, but if you ignore that, the difference is negligible and in line with the trend. Now, I'm not saying we shouldn't do anything here, that increasing trend should be explained, and so should the dip, but I'm reluctant to back this out unless you can give me something a bit more solid.
You need to log in
before you can comment on or make changes to this bug.
Description
•