487197 - liboggplay failed to compile on OpenSolaris

Status: VERIFIED FIXED

(Core :: Audio/Video, defect)

Description

[Ginn Chen]

The code is not compatible with Sun Studio 12 compiler
e.g. __asm__ is not supported, ATTR_ALIGN(16) is not supported either
Also using inline asm of SSE2 with Sun Studio 12 may makes Firefox binary won't run on a machine without SSE2. Because SSE2 is added to HWCAP of the binary.

I think we may want to disable all inline asm for Sun Studio 12 in this module for now.
We can check __SUNPRO_C.

Comment 1

[Ginn Chen]

Attachment: patch

Disable the feature for Sun Studio for now.

return with statement should not be used in void function, although gcc allows it.

Comment 2

[Matthew Gregan [:kinetik]]

(In reply to comment #1)
> return with statement should not be used in void function, although gcc allows
> it.

Oops, sorry about that.  It's legal to do that in C++, but not in C.

Comment 3

[Ginn Chen]

Attachment: patch v2

Update to current trunk/1.9.1

Comment 4

[Ginn Chen]

Attachment: patch v3

Update to HEAD

Comment 5

[Ginn Chen]

Fix integrated by http://hg.mozilla.org/mozilla-central/rev/fb6d235b9efb

Comment 6

[Ginn Chen]

Reopen, since it was backed out.

Comment 7

[Chris Pearce [:cpearce (Not reading bugmail)]]

Requires liboggplay changeset 5814d283ef6458a9b9472b1b307c968f70b4cfaa to fix.

Comment 8

[Chris Pearce [:cpearce (Not reading bugmail)]]

Fixed on trunk and 1.9.2 by bug 512328 checkin.

Ginn can you please verify that this is fixed, and reopen if it's not fixed?

Comment 9

[Chris Pearce [:cpearce (Not reading bugmail)]]

Fixed on 1.9.1 by checkin of bug 512328 on 1.9.1.