487250 - When textbox content is generated by a specific xml template, the content disappears on focus

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect)

Description

[Nick P]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.0.8) Gecko/2009032608 Firefox/3.0.8
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.3) Gecko/2008092521

When an xml template variable is created using text(), and this variable is used to assign a value to a textbox, the textbox loses its content when it is clicked.  The text is also grayed out.  Upon focus, the textbox goes blank.

Reproducible: Always

Steps to Reproduce:
1.  Create XML template as outlines above
2.  Observe the color of the text in the textboxes
3.  Click in a textbox
Actual Results:  
The textbox content is gray, and when clicked it disappears

Expected Results:  
The textbox content should have been black, and when clicked it should have remained visible.

Comment 1

[Nick P]

Attachment: This xul file demonstrates the textbox/template problem.

Comment 2

[Nick P]

Enn noted that "looks like the empty attribute set by the template conflicts with the similarly named empty attribute from the textbox"

and pointed out a workaround - setting the template's flags attribute to "dont-test-empty"

Comment 3

[Neil Deakin]

We should change textbox's empty attribute to something else. It's only used internally and by themes so something similar could be used.

Comment 4

[Dão Gottwald [:dao]]

I would suggest moz-empty, which would reflect that it's used internally and be consistent with moz-collapsed. But I suppose you're against the hyphen here too?

Comment 5

[Neil Deakin]

isempty ?

What is moz-collapsed?

Comment 6

[Dão Gottwald [:dao]]

xul.css defines moz-collapsed as an alias for collapsed. It's used where collapsed isn't wanted because it would be persisted, or something like that...

Comment 7

[Dão Gottwald [:dao]]

Attachment: rename internal attribute to "isempty"

Comment 8

[Dão Gottwald [:dao]]

Comment on attachment 373737 [details] [diff] [review]
rename internal attribute to "isempty"

>--- a/browser/themes/pinstripe/browser/searchbar.css
>+++ b/browser/themes/pinstripe/browser/searchbar.css

>-#searchbar[empty="true"] .search-go-button {
>-  visibility: hidden;
>-}

This is a no-op. #searchbar isn't a textbox and never had the "empty" attribute.

Comment 9

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/9583c67570f5