Closed Bug 487263 Opened 15 years ago Closed 15 years ago

dragging a tab up or over the tab bar then out of the window does not detach

Categories

(Firefox :: Tabbed Browser, defect, P2)

3.5 Branch
defect

Tracking

()

VERIFIED FIXED
Firefox 3.5

People

(Reporter: kbrosnan, Assigned: asaf)

References

Details

(Keywords: verified1.9.1)

Attachments

(1 file)

Create 3 tabs, drag the center tab along the tab bar to the left or right, release outside the browser tab is not detached.
Flags: blocking-firefox3.5?
Status: NEW → RESOLVED
Closed: 15 years ago
Flags: blocking-firefox3.5?
Resolution: --- → DUPLICATE
Still a problem on Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2a1pre) Gecko/20090421 Minefield/3.6a1pre
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Assignee: nobody → mano
Flags: blocking-firefox3.5+
OS: Windows 7 → All
Priority: -- → P2
Target Milestone: --- → Firefox 3.5
Hardware: x86 → All
Summary: dragging a tab over the tab bar then out of the window does not detach → dragging a tab up or over the tab bar then out of the window does not detach
Whiteboard: [eta 5/12]
Attached patch patchSplinter Review
This patch also fixes bug 491530
Whiteboard: [eta 5/12]
Attachment #377975 - Flags: review?(dietrich)
Attachment #377975 - Flags: review?(dietrich) → review+
Comment on attachment 377975 [details] [diff] [review]
patch

>+            // Disable deatch within the browser toolbox

s/deatch/detach/

http://mxr.mozilla.org/mozilla-central/search?string=deatch

>+            var eX = aEvent.screenX;
>+            var wX = window.screenX;
>+            // check if the drop point is horizontally within the window
>+            if (eX > wX && eX < window.screenX + window.outerWidth) {  

s/window.screenX/wX/

also, maybe wrap that the "window.screenX + window.outerWidth" bit in parens for readability

remove extra whitespace at end of line

otherwise this seems ok... but i'm not that familiar with this code, so you should get a review from a qualified tabbrowser.xml reviewer.

(and x-moz-text-internal is far too ambiguously named for my taste, but that's a different issue :P)
Comment on attachment 377975 [details] [diff] [review]
patch

r=me with dietrich's review comments addressed.
Attachment #377975 - Flags: review+
Whiteboard: [has reviews][needs new patch]
Whiteboard: [has reviews][needs new patch] → [has reviews][can land]
Mano, as said this fixes the homepage button too, but what about the new tab button? It doesn't accept the dropped tab and no new tab is opened. Is there an open bug or shall I file a new one?
Did it use to work, if so please file a bug and I'll fix it immediately.
(In reply to comment #12)
> Did it use to work, if so please file a bug and I'll fix it immediately.

Filed bug 494026 on that. It's a regression against Firefox 3 too.
henrik, is this verified then?
Ok, I tried the steps from comment 0 and I cannot get it to work on OS X and Linux. All 4 builds fail. Only the two builds on Windows show the correct behavior. That makes it not fixed => Reopen.

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090522 Minefield/3.6a1pre ID:20090522032716

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1pre) Gecko/20090521 Shiretoko/3.5pre ID:20090521135222
Status: RESOLVED → REOPENED
Keywords: fixed1.9.1
Resolution: FIXED → ---
Whiteboard: [has reviews][can land]
Henrik, I've filed bug 494795 for that, as it's slightly different but likely related. What seems to be happening is that on OSX and Linux we're only checking to see if it's gone vertically off the tabstrip; if you stay within the tabstrip height, you can never get it to detach. This bug got morphed to be about having to go up-and-over.

Returning this to FIXED and fixed1.9.1.
Status: REOPENED → RESOLVED
Closed: 15 years ago15 years ago
Keywords: fixed1.9.1
Resolution: --- → FIXED
Alright. Marking verified fixed based on my comment 15.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.