Closed
Bug 487263
Opened 15 years ago
Closed 15 years ago
dragging a tab up or over the tab bar then out of the window does not detach
Categories
(Firefox :: Tabbed Browser, defect, P2)
Tracking
()
VERIFIED
FIXED
Firefox 3.5
People
(Reporter: kbrosnan, Assigned: asaf)
References
Details
(Keywords: verified1.9.1)
Attachments
(1 file)
3.61 KB,
patch
|
dietrich
:
review+
mconnor
:
review+
|
Details | Diff | Splinter Review |
Create 3 tabs, drag the center tab along the tab bar to the left or right, release outside the browser tab is not detached.
Flags: blocking-firefox3.5?
Updated•15 years ago
|
Status: NEW → RESOLVED
Closed: 15 years ago
Flags: blocking-firefox3.5?
Resolution: --- → DUPLICATE
Reporter | ||
Comment 2•15 years ago
|
||
Still a problem on Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2a1pre) Gecko/20090421 Minefield/3.6a1pre
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Comment 3•15 years ago
|
||
Either this or https://bugzilla.mozilla.org/show_bug.cgi?id=489339 is a dupe.
Updated•15 years ago
|
Assignee: nobody → mano
Flags: blocking-firefox3.5+
OS: Windows 7 → All
Priority: -- → P2
Target Milestone: --- → Firefox 3.5
Updated•15 years ago
|
Hardware: x86 → All
Reporter | ||
Updated•15 years ago
|
Summary: dragging a tab over the tab bar then out of the window does not detach → dragging a tab up or over the tab bar then out of the window does not detach
Updated•15 years ago
|
Whiteboard: [eta 5/12]
Assignee | ||
Comment 6•15 years ago
|
||
Assignee | ||
Updated•15 years ago
|
Attachment #377975 -
Flags: review?(dietrich)
Updated•15 years ago
|
Attachment #377975 -
Flags: review?(dietrich) → review+
Comment 8•15 years ago
|
||
Comment on attachment 377975 [details] [diff] [review] patch >+ // Disable deatch within the browser toolbox s/deatch/detach/ http://mxr.mozilla.org/mozilla-central/search?string=deatch >+ var eX = aEvent.screenX; >+ var wX = window.screenX; >+ // check if the drop point is horizontally within the window >+ if (eX > wX && eX < window.screenX + window.outerWidth) { s/window.screenX/wX/ also, maybe wrap that the "window.screenX + window.outerWidth" bit in parens for readability remove extra whitespace at end of line otherwise this seems ok... but i'm not that familiar with this code, so you should get a review from a qualified tabbrowser.xml reviewer. (and x-moz-text-internal is far too ambiguously named for my taste, but that's a different issue :P)
Comment 9•15 years ago
|
||
Comment on attachment 377975 [details] [diff] [review] patch r=me with dietrich's review comments addressed.
Attachment #377975 -
Flags: review+
Updated•15 years ago
|
Whiteboard: [has reviews][needs new patch]
Updated•15 years ago
|
Whiteboard: [has reviews][needs new patch] → [has reviews][can land]
Assignee | ||
Comment 10•15 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/e1b547419223 http://hg.mozilla.org/mozilla-central/rev/488aff0b2591 http://hg.mozilla.org/releases/mozilla-1.9.1/rev/ade0a3dc3154
Status: REOPENED → RESOLVED
Closed: 15 years ago → 15 years ago
Resolution: --- → FIXED
Comment 11•15 years ago
|
||
Mano, as said this fixes the homepage button too, but what about the new tab button? It doesn't accept the dropped tab and no new tab is opened. Is there an open bug or shall I file a new one?
Assignee | ||
Comment 12•15 years ago
|
||
Did it use to work, if so please file a bug and I'll fix it immediately.
Comment 13•15 years ago
|
||
(In reply to comment #12) > Did it use to work, if so please file a bug and I'll fix it immediately. Filed bug 494026 on that. It's a regression against Firefox 3 too.
Updated•15 years ago
|
Keywords: fixed1.9.1
Comment 14•15 years ago
|
||
henrik, is this verified then?
Comment 15•15 years ago
|
||
Ok, I tried the steps from comment 0 and I cannot get it to work on OS X and Linux. All 4 builds fail. Only the two builds on Windows show the correct behavior. That makes it not fixed => Reopen. Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090522 Minefield/3.6a1pre ID:20090522032716 Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1pre) Gecko/20090521 Shiretoko/3.5pre ID:20090521135222
Status: RESOLVED → REOPENED
Keywords: fixed1.9.1
Resolution: FIXED → ---
Whiteboard: [has reviews][can land]
Comment 16•15 years ago
|
||
Henrik, I've filed bug 494795 for that, as it's slightly different but likely related. What seems to be happening is that on OSX and Linux we're only checking to see if it's gone vertically off the tabstrip; if you stay within the tabstrip height, you can never get it to detach. This bug got morphed to be about having to go up-and-over. Returning this to FIXED and fixed1.9.1.
Updated•15 years ago
|
Status: REOPENED → RESOLVED
Closed: 15 years ago → 15 years ago
Keywords: fixed1.9.1
Resolution: --- → FIXED
Comment 17•15 years ago
|
||
Alright. Marking verified fixed based on my comment 15.
Status: RESOLVED → VERIFIED
Keywords: fixed1.9.1 → verified1.9.1
You need to log in
before you can comment on or make changes to this bug.
Description
•