487302 - make menus look more OS/2 alike

Status: RESOLVED FIXED

(Toolkit :: Themes, defect)

Description

[Walter Meinl]

User-Agent:       Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.9.2a1pre) Gecko/20090406 Minefield/3.6a1pre
Build Identifier: 

see https://bugzilla.mozilla.org/show_bug.cgi?id=472373#c3

Reproducible: Always

Comment 1

[Walter Meinl]

Attachment: fix

will attach a screenshot later

Comment 2

[Walter Meinl]

Attachment: comparison between minefield and ecenter

The promised screenshot. Still missing:
I couldn't find a way to get the main menu panes shifted 2 px to the left  with regard to the titles by manipulating either popup.css or menu.css in pmstripe.

Comment 3

[Peter Weilbacher]

Comment on attachment 371526 [details] [diff] [review]
fix

The patch is DOS format again, but otherwise I think this is a definitive improvement. Thanks.

Comment 4

[Walter Meinl]

Attachment: fix w/ UNIX-endings [Checkin: Comment 5]

(In reply to comment #3)
> (From update of attachment 371526 [details] [diff] [review])
> The patch is DOS format again, but otherwise I think this is a definitive
> improvement. Thanks.

:-( forgotten again! Now with corrected line endings.

Comment 5

[Serge Gautherie (:sgautherie)]

Comment on attachment 371935 [details] [diff] [review]
fix w/ UNIX-endings
[Checkin: Comment 5]


http://hg.mozilla.org/mozilla-central/rev/3b9494885fb8

Comment 6

[Walter Meinl]

Attachment: screenshot of applied branch patch

This shows the menus with a similar patch (comes up). It was a bit trickier and I couldn't get as well looking as the trunk: it overlaps a bit more on the left side when the right side is aligned properly. But when I aligning it on the left side correctly had the consequence that it then overlapped more on the right side (sigh!) I tested various pixel values in popup.css, but that's the best (at least for me) solution.

Comment 7

[Walter Meinl]

Attachment: patch for the branches

If you like it, we could consider to take it even for the 1.9.0 branch

Comment 8

[Peter Weilbacher]

Comment on attachment 373357 [details] [diff] [review]
patch for the branches

Why does this one have a -moz-margin-start of 0 in popup.css? (It should be 0 and not 0px if I recall the CSS spec correctly).

Comment 9

[Walter Meinl]

(In reply to comment #8)
> (From update of attachment 373357 [details] [diff] [review])
> Why does this one have a -moz-margin-start of 0 in popup.css? (It should be 0
> and not 0px if I recall the CSS spec correctly).

Well, it's probably a left over from trying various values. I'll try if I can just omit the whole moz-margin-start line or have to set it to 0 (w/o dimension).

Comment 10

[Walter Meinl]

Attachment: better branch patch [Checkin: Comment 12]

removing -moz-margin-start has the same effect.

Comment 11

[Peter Weilbacher]

Comment on attachment 373758 [details] [diff] [review]
better branch patch [Checkin: Comment 12]

I would still like to know what causes this specific difference between trunk and branches to be necessary...

Comment 12

[Peter Weilbacher]

But anyway, if it works, that's OK.

Checked into CVS for 1.9.0:
Checking in toolkit/themes/pmstripe/global/menu.css;
new revision: 1.8; previous revision: 1.7
Checking in toolkit/themes/pmstripe/global/popup.css;
new revision: 1.4; previous revision: 1.3

and Hg for 1.9.1:
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/c11afdb243c8

Comment 13

[Walter Meinl]

(In reply to comment #11)
> (From update of attachment 373758 [details] [diff] [review])
> I would still like to know what causes this specific difference between trunk
> and branches to be necessary...

The difference with regard to the position of popups is bug279539 that was only applied to trunk

Comment 14

[Peter Weilbacher]

Ah, of course! Thanks for reminding me. (Hmm, should there be some dependency between the bugs involved?)