Closed Bug 487320 Opened 14 years ago Closed 14 years ago

named function objects can escape without detection by the upvar analysis

Categories

(Core :: JavaScript Engine, defect, P1)

defect

Tracking

()

VERIFIED FIXED
mozilla1.9.2a1

People

(Reporter: brendan, Assigned: brendan)

Details

(4 keywords)

Attachments

(2 files, 1 obsolete file)

Attached file js shell testcase (obsolete) —
Second unaddressed todo item from bug 487215:

* named function expr name not flagged via PND_FUNARG

We can handle this too.

/be
Flags: blocking1.9.1?
Flags: blocking1.9.1? → blocking1.9.1+
Assignee: mrbkap → brendan
Status: NEW → ASSIGNED
Priority: -- → P1
Summary: Crash [@ js_Interpret ] → named function objects can escape without detection by the upvar analysis
Attached patch fixSplinter Review
See the comment for the whole story.

/be
Attachment #371571 - Flags: review?(mrbkap)
Attachment #371571 - Flags: review?(mrbkap) → review+
Fixed on tm and m-c:

http://hg.mozilla.org/tracemonkey/rev/7758faede5b2
http://hg.mozilla.org/mozilla-central/rev/202671f30992

/be
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Tweaked the comment after attaching the patch that got r+ -- see the hgweb links.

/be
is there a concise test case for this?
(In reply to comment #5)
> is there a concise test case for this?

The attachment 371570 [details] is pretty short -- is that not good enough?

/be
sorry, didn't see it
Flags: in-testsuite?
Status: RESOLVED → VERIFIED
Target Milestone: mozilla1.9.1b4 → mozilla1.9.2a1
Automatically extracted testcase for this bug was committed:

https://hg.mozilla.org/mozilla-central/rev/efaf8960a929
Flags: in-testsuite? → in-testsuite+
You need to log in before you can comment on or make changes to this bug.