487320 - named function objects can escape without detection by the upvar analysis

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect, P1)

Description

[Brendan Eich [:brendan]]

Attachment: js shell testcase

Second unaddressed todo item from bug 487215:

* named function expr name not flagged via PND_FUNARG

We can handle this too.

/be

Comment 1

[Brendan Eich [:brendan]]

Attachment: nicer layout for testcase (one line per statement in the nested function)

Comment 2

[Brendan Eich [:brendan]]

Attachment: fix

See the comment for the whole story.

/be

Comment 3

[Brendan Eich [:brendan]]

Fixed on tm and m-c:

http://hg.mozilla.org/tracemonkey/rev/7758faede5b2
http://hg.mozilla.org/mozilla-central/rev/202671f30992

/be

Comment 4

[Brendan Eich [:brendan]]

Tweaked the comment after attaching the patch that got r+ -- see the hgweb links.

/be

Comment 5

[Robert Sayre]

is there a concise test case for this?

Comment 6

[Brendan Eich [:brendan]]

(In reply to comment #5)
> is there a concise test case for this?

The attachment 371570 [details] is pretty short -- is that not good enough?

/be

Comment 7

[Robert Sayre]

sorry, didn't see it

Comment 8

[Robert Sayre]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/9b8ef421296c

Comment 9

[Christian Holler (:decoder)]

Automatically extracted testcase for this bug was committed:

https://hg.mozilla.org/mozilla-central/rev/efaf8960a929