Closed
Bug 487358
Opened 16 years ago
Closed 16 years ago
"Content may be out of date" warning should only list English edit
Categories
(support.mozilla.org :: Knowledge Base Software, task)
support.mozilla.org
Knowledge Base Software
Tracking
(Not tracked)
VERIFIED
FIXED
1.3
People
(Reporter: cilias, Assigned: paulc)
References
()
Details
(Whiteboard: tiki_bug, tiki_upstreamed)
Attachments
(1 file)
2.53 KB,
patch
|
laura
:
review+
|
Details | Diff | Splinter Review |
I'm not sure why, but the "Content may be out of date" warning sometimes lists more than just the English article. For instance, going to <https://support-stage.mozilla.org/nl/kb/Firefox+installeren+op+Mac>, I see:
Content may be out of date
An important change has been made on another language version of this page. Until this page is updated, you can view the following updated versions:
Installing Firefox on Mac (en) - View changes and update currently viewed language version
Instalando o Firefox no Mac (pt-BR) - View changes and update currently viewed language version
Installere Firefox på Mac (no) - View changes and update currently viewed language version
Firefoxin asentaminen Macille (fi) - View changes and update currently viewed language version
Installer Firefox sur Mac (fr) - View changes and update currently viewed language version
Firefox unter Mac installieren (de) - View changes and update currently viewed language version
Cài đặt Firefox trên Mac (vi) - View changes and update currently viewed language version
It looks ugly, and we should only list the English edit.
Assignee | ||
Comment 1•16 years ago
|
||
Have you noticed a difference in the diff's?
My suspicion is that it lists all oudated translations + English. Perhaps :D... perhaps not.
Assignee: nobody → paul.craciunoiu
Comment 2•16 years ago
|
||
We need to investigate why these other languages are appearing. The warning should notify of other articles that are _newer_ than the one you're currently reading -- if it's listing all outdated translations, that's completely the opposite of what we want.
It is currently only possible for an en-US article to be "newer" than other articles in terms of up-to-dateness, so why we're seeing all these other articles listed is a mystery...
Assignee | ||
Comment 3•16 years ago
|
||
(In reply to comment #2)
> It is currently only possible for an en-US article to be "newer" than other
> articles in terms of up-to-dateness, so why we're seeing all these other
> articles listed is a mystery...
I assume by this you mean that only en-US articles have the "mark as out of date" checkbox. It certainly looks like this is the case. The translation system does not assume that in the background, however. I could simply force it to always show the English version only, since it appears that this is the only version that is always guaranteed to show on the list (i.e. there will be no situation in which other locales show up and English does not, on this list).
The best solution to me seems to only show the English version and leave the implementation be as it is.
Assignee | ||
Comment 4•16 years ago
|
||
Attachment #386592 -
Flags: review?(smirkingsisyphus)
Attachment #386592 -
Flags: review?(laura)
Assignee | ||
Updated•16 years ago
|
Target Milestone: --- → 1.3
Assignee | ||
Comment 5•16 years ago
|
||
I haven't fully tested, but I think this patch hides the notification entirely _unless_ the English article marked other translations as out of date. If we always expect the English article to be "ahead", then it should be fine.
Updated•16 years ago
|
Attachment #386592 -
Flags: review?(smirkingsisyphus)
Attachment #386592 -
Flags: review?(laura)
Attachment #386592 -
Flags: review+
Assignee | ||
Comment 6•16 years ago
|
||
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Comment 7•16 years ago
|
||
(In reply to comment #5)
> I haven't fully tested, but I think this patch hides the notification entirely
> _unless_ the English article marked other translations as out of date. If we
> always expect the English article to be "ahead", then it should be fine.
Is this a valid assumption? Chris? David? I just want to make sure before I verify; thanks!
Reporter | ||
Comment 8•16 years ago
|
||
The "Alert translators" checkbox only appears when editing English articles, so that's fine.
Comment 9•16 years ago
|
||
I tested this when I wrote comment 7, but just didn't verify, pending that question (I did so by creating an en-US article, then a translation, then updating the en-US article, etc.)
Verified FIXED now.
Status: RESOLVED → VERIFIED
Assignee | ||
Comment 10•16 years ago
|
||
Since there is a potential risk, maybe we should have a bug to add a pref for enabling/disabling this behavior -- so we can have a workaround. Laura?
Assignee | ||
Comment 11•15 years ago
|
||
I found this revision that supposedly limited the alerts to one:
http://viewvc.svn.mozilla.org/vc?view=revision&revision=10608
If this bug gets reopened, investigation can start from there.
Updated•15 years ago
|
Whiteboard: tiki_bug
Comment 12•15 years ago
|
||
I don't like this fix as it breaks a major feature: not being forced on a master language. The list provides all the possible sources for the update.
With the introduction of the option to only allow urgent translations from the site language, I would upstream this one with
Whiteboard: tiki_bug → tiki_bug, tiki_upstreamed
Assignee | ||
Comment 13•15 years ago
|
||
LPH: seems like that last phrase is missing an ending?
Comment 14•15 years ago
|
||
Yes, seems like I got distracted mid-sentence. Happens a lot.
Anyway, I didn't apply the changes to the query and filter the results afterwards instead based on the other related preferences.
You need to log in
before you can comment on or make changes to this bug.
Description
•