48737 - [MLK] Leaking result of SSM_PickleResource()

Status: VERIFIED FIXED

(Core :: Security: PSM, defect, P3)

Description

[Patrick C. Beard]

The variable certBlob is leaking. It is allocated in SSMResourceCert_Pickle() but 
never freed. The call site is in the URL field above.

Comment 1

[Patrick C. Beard]

Reassigning to ddrinan.

Comment 2

[David P. Drinan]

Setting nsbeta3

Comment 3

[Michael La Guardia]

Leaving a mark here to say that I looked at the bug.  There's no information
here about the severity of the leak, so I can't evaluate how important this is
to fix for beta 3.  I suggest that we include this bug in the embedding review.
 Adding embed keyword.  I'm sure someone will correct me if I'm wrong about this.

Comment 4

[Michael La Guardia]

Jud, will you take a look at this to determine if this is something you need for
embedding?  I'm marking nsbeta3- for the time being.

Comment 5

[Judson Valeski]

yea, we need this. it's a simple fix too (based on a quick glance at the code).

Comment 6

[Michael La Guardia]

OK.  Marking nsbeta3+ for embedding per Jud's comment.

Comment 7

[lchiang]

Jud - do you want this in the nsbeta3/rtm branch?  I can't tell.  Per my email
with you, changing nsbeta3+ to nsbeta3- on all "embed" keyword bugs
since embedding changes will not be made in the mn6 branch.  If this bug is an
exception, pls nominate for rtm.

Comment 8

[John Unruh]

Changing QA contact to nitinp

Comment 9

[John Unruh]

Mass reassigning nitinp's bugs to me.

Comment 10

[John Unruh]

nsbeta1

Comment 11

[Judson Valeski]

is this even relevant w/ psm 2.0?

Comment 12

[John Unruh]

Marking fixed. This bug is not relevant now that PSM 2.0 is integrated into the 
nightly builds.

Comment 13

[John Unruh]

verified fixed.