487427 - [Extension] Comments not appearing in published add-ons

Reporter

Description

•

15 years ago

When I publish an add-on to a collection, the comment I write does not appear in the listing.

Brian King [:kinger]

Reporter

Updated

•

15 years ago

Blocks: 470228

Justin Scott [:fligtar]

Comment 1

•

15 years ago

Moving to revised M5 milestone (4/28).

OS: Windows Vista → All

Hardware: x86 → All

Target Milestone: BW-M3 → BW-M5

David McNamara [:mackers]

Assignee

Comment 2

•

15 years ago

I can't reproduce this.

Any more details? Can you attach the debug console output when you do the publish and when it retrieves the collection.

Brian King [:kinger]

Reporter

Comment 3

•

15 years ago

Here is the add-on published, followed by the output for the subscription published to. Note empty comments fields. Possibly this is an API bug?

bandwagon(5): Bandwagon.RPC.Net.send.onreadystatechange: 702431766701838: completed, response text = '<?xml version="1.0" encoding="utf-8" ?>
<addon xml:base="https://bandwagon.stage.mozilla.com/en-US/firefox/api/1.3/sharing//collections/7876989a-692f-102c-9a23-001e0bd9232c/addons/%7B9bc51d13-3849-4541-a69c-da418934ca05%7D">
    <meta>
        <added>2009-04-08T07:32:18-07:00</added>
        <addedby>kinger</addedby>
        <comments></comments>
        <collection href=".." />    </meta>
    <categories>
            <category id="14">Appearance</category>
        </categories>
    <name>FfChrome</name>
    <type id='1'>Extension</type>
    <guid>{9bc51d13-3849-4541-a69c-da418934ca05}</guid>
    <version>56609</version>
    <status id='4'>Public</status>
    <authors>
          <author>Shivanand Sharma</author>
    </authors>      
    <summary>FfChrome is an extension that slims and trims your context menu on the fly for simplicity, ease of use, easy access and eliminates the clutter.</summary>
    <description>FfChrome is an extension that slims and trims your context menus on the fly for simplicity, ease of use, easy access and eliminates the clutter.

Menus show only the essential items by default. You can hover the mouse on &quot;Show All&quot; and menus expand on the fly.</description>
    <icon>https://addons.mozilla.org/img/default_icon.png</icon>
    <compatible_applications>
            <application>
            <name>Firefox</name>
            <application_id>1</application_id>
            <min_version>3.0b2</min_version>
            <max_version>3.0.*</max_version>
            <appID>{ec8030f7-c20a-464f-9b0e-13a3a9e97384}</appID>
             </application>
         </compatible_applications>      
        <all_compatible_os>
            <os>ALL</os>
                    </all_compatible_os>
        <eula></eula>
    <thumbnail>https://addons.mozilla.org/en-US/firefox/images/t/26318/1222434600</thumbnail>
    <rating>4</rating>
    <learnmore>https://addons.mozilla.org/addon/9023</learnmore>
             <install hash='sha256:5be5363df8cde0d1a82b721f1c64468b3c976644e486368fc4e852054cd06589' os='ALL'>https://addons.mozilla.org/downloads/file/40469/ffchrome-1.6-fx.xpi</install>          
         </addon>
 
'

----

bandwagon(5): Bandwagon.RPC.Net.send.onreadystatechange: 702431782721087: completed, response text = '<?xml version="1.0" encoding="utf-8" ?>
<collection xmlns="http://addons.mozilla.org/" 
    xml:base="https://bandwagon.stage.mozilla.com/en-US/firefox/api/1.3/sharing//collections/7876989a-692f-102c-9a23-001e0bd9232c/"
    name="Tab Productivity"
    icon="http://addons.mozilla.org/img/collection.png"
    type="normal"
    description="Tabs only."
    app=""
    creator="kinger"
    listed="yes" writable="yes" subscribed="yes" 
    lastmodified="2009-04-17T05:59:55-07:00">

    <links xml:base="https://bandwagon.stage.mozilla.com/en-US/firefox/">
        <link id="view" href="collections/view/7876989a-692f-102c-9a23-001e0bd9232c" />
        <link id="subscribe" href="collections/subscribe/7876989a-692f-102c-9a23-001e0bd9232c" />
        <link id="unsubscribe" href="collections/unsubscribe/7876989a-692f-102c-9a23-001e0bd9232c" />
    </links>

    <addons href="addons/">
        
    
<addon href="addons/multipletab%40piro.sakura.ne.jp/">
    <meta>
        <added>2009-04-08T23:40:54-07:00</added>
        <addedby>kinger</addedby>
        <comments></comments>
            </meta>
    <categories>
            <category id="93">Tabs</category>
        </categories>
    <name>Multiple Tab Handler</name>
    <type id='1'>Extension</type>
    <guid>multipletab@piro.sakura.ne.jp</guid>
    <version>55727</version>
    <status id='4'>Public</status>
    <authors>
          <author>SHIMODA Hiroshi</author>
    </authors>      
    <summary>Provides feature to close multiple tabs.</summary>
    <description>This provides features to handle multiple tabs at once, for example, close them, reload them, and so on. When you press the mouse button and drag over tabs (you should wait a while to start drag after you press down the button!), they are selected. After you release the button, the popup to choose command will be shown. Of course, you can toggle selection by Ctrl-click on each tab and call features from the context menu. Yes, the behavior looks like Excel.

You can move tabs with drag and drop if you start to drag on a tab after you press the mouse button immediately. Multiple tabs can be dragged and moved if you select multiple tabs by Ctrl-click or Shift-click before you start to drag.

This emulates some features of &quot;iRider&quot;. Selecting of closeboxes can close tabs directly, and you can switch tabs by dragging on tabs. (require configuration)
See also Tree Style Tab ( https://addons.mozilla.org/firefox/addon/5890 ).

By the way, this includes &quot;Duplicate Tab&quot;, &quot;Close All Tabs&quot;, &quot;Close Left Tabs&quot;, &quot;Close Right Tabs&quot;, &quot;Copy URL&quot; and &quot;Close Slimilar Tabs&quot; features.

This is developed under a project to restructure TBE for Firefox 2. See also Informational Tab ( https://addons.mozilla.org/firefox/addon/4930 ).</description>
    <icon>https://addons.mozilla.org/en-US/firefox/images/addon_icon/4838/1226664732</icon>
    <compatible_applications>
            <application>
            <name>Firefox</name>
            <application_id>1</application_id>
            <min_version>2.0</min_version>
            <max_version>3.1b2pre</max_version>
            <appID>{ec8030f7-c20a-464f-9b0e-13a3a9e97384}</appID>
             </application>
         </compatible_applications>      
        <all_compatible_os>
            <os>ALL</os>
                    </all_compatible_os>
        <eula></eula>
    <thumbnail>https://addons.mozilla.org/en-US/firefox/images/t/13538/1177042785</thumbnail>
    <rating>5</rating>
    <learnmore>https://addons.mozilla.org/addon/4838</learnmore>
             <install hash='sha256:e39c44ed343c70ce37d2957200889bf3eaf3b0b99934e7f38d8db0a5baa58119' os='ALL'>https://addons.mozilla.org/downloads/file/39532/multiple_tab_handler-0.3.2008101801-fx.xpi</install>          
         </addon>
    
    
<addon href="addons/tabhunter%40ericpromislow.com/">
    <meta>
        <added>2009-04-08T07:32:22-07:00</added>
        <addedby>kinger</addedby>
        <comments></comments>
            </meta>
    <categories>
            <category id="93">Tabs</category>
        </categories>
    <name>Tabhunter</name>
    <type id='1'>Extension</type>
    <guid>tabhunter@ericpromislow.com</guid>
    <version>50784</version>
    <status id='4'>Public</status>
    <authors>
          <author>Eric Promislow</author>
    </authors>      
    <summary>Find tabs in Mozilla-based browsers easily</summary>
    <description>This extension lets users of Firefox, Flock, and other browsers based on Mozilla easily juggle dozens of tabs at any time.  Enter a search string (actually a standard JavaScript regex), highlight the URL you want to bring up, and press return or double-click it.  Tabhunter will even bring up minimized windows containing the target tab.

Inspired by Davide Ficano&#39;s tab selector extension for ActiveState&#39;s Komodo IDE, and my own need to bring my ever-growing web-based workload under control.  Under no circumstances should this software be confused with Tab Hunter, an actor best known for his work in the mid-20th century.</description>
    <icon>https://addons.mozilla.org/en-US/firefox/images/addon_icon/7924/1216936720</icon>
    <compatible_applications>
            <application>
            <name>Firefox</name>
            <application_id>1</application_id>
            <min_version>2.0</min_version>
            <max_version>3.0.*</max_version>
            <appID>{ec8030f7-c20a-464f-9b0e-13a3a9e97384}</appID>
             </application>
         </compatible_applications>      
        <all_compatible_os>
            <os>ALL</os>
                    </all_compatible_os>
        <eula></eula>
    <thumbnail>https://addons.mozilla.org/en-US/firefox/images/t/22721/1214806606</thumbnail>
    <rating>5</rating>
    <learnmore>https://addons.mozilla.org/addon/7924</learnmore>
             <install hash='sha256:98b2a487db2fe2f1a2606bcedd53dd06aeda87d6fd7c03ebdaae58ec85294f3e' os='ALL'>https://addons.mozilla.org/downloads/file/34341/tabhunter-0.6.9-fx.xpi</install>          
         </addon>
    
    
<addon href="addons/%7B9bc51d13-3849-4541-a69c-da418934ca05%7D/">
    <meta>
        <added>2009-04-08T07:32:18-07:00</added>
        <addedby>kinger</addedby>
        <comments></comments>
            </meta>
    <categories>
            <category id="14">Appearance</category>
        </categories>
    <name>FfChrome</name>
    <type id='1'>Extension</type>
    <guid>{9bc51d13-3849-4541-a69c-da418934ca05}</guid>
    <version>56609</version>
    <status id='4'>Public</status>
    <authors>
          <author>Shivanand Sharma</author>
    </authors>      
    <summary>FfChrome is an extension that slims and trims your context menu on the fly for simplicity, ease of use, easy access and eliminates the clutter.</summary>
    <description>FfChrome is an extension that slims and trims your context menus on the fly for simplicity, ease of use, easy access and eliminates the clutter.

Menus show only the essential items by default. You can hover the mouse on &quot;Show All&quot; and menus expand on the fly.</description>
    <icon>https://addons.mozilla.org/img/default_icon.png</icon>
    <compatible_applications>
            <application>
            <name>Firefox</name>
            <application_id>1</application_id>
            <min_version>3.0b2</min_version>
            <max_version>3.0.*</max_version>
            <appID>{ec8030f7-c20a-464f-9b0e-13a3a9e97384}</appID>
             </application>
         </compatible_applications>      
        <all_compatible_os>
            <os>ALL</os>
                    </all_compatible_os>
        <eula></eula>
    <thumbnail>https://addons.mozilla.org/en-US/firefox/images/t/26318/1222434600</thumbnail>
    <rating>4</rating>
    <learnmore>https://addons.mozilla.org/addon/9023</learnmore>
             <install hash='sha256:5be5363df8cde0d1a82b721f1c64468b3c976644e486368fc4e852054cd06589' os='ALL'>https://addons.mozilla.org/downloads/file/40469/ffchrome-1.6-fx.xpi</install>          
         </addon>
    
    </addons>

</collection>
 
'

David McNamara [:mackers]

Assignee

Comment 4

•

15 years ago

Brian, please include the debug console output for the actual publish request. I.e. the few lines before what you've sent.

Brian King [:kinger]

Reporter

Comment 5

•

15 years ago

(In reply to comment #4)
> Brian, please include the debug console output for the actual publish request.
> I.e. the few lines before what you've sent.

bandwagon(5): Bandwagon.RPC.Service.publishToCollection: extension.guid = 'inspector@mozilla.org', extension.name = 'DOM Inspector', collection = 'https://bandwagon.stage.mozilla.com/en-US/firefox/api/1.3/sharing//collections/7876989a-692f-102c-9a23-001e0bd9232c/', personalNote = 'Test 1 2 3'

bandwagon(5): Bandwagon.RPC.Service: sending rpc immediately

bandwagon(5): Bandwagon.RPC.Net.send: 702482212271832: opening POST XMLHttpRequest to https://bandwagon.stage.mozilla.com/en-US/firefox/api/1.3/sharing//collections/7876989a-692f-102c-9a23-001e0bd9232c/addons/

bandwagon(5): Bandwagon.RPC.Net.send: 702482212271832: sending XMLHttpRequest  with data "guid=inspector%40mozilla.org&comments=Test%201%202%203"

bandwagon(5): Bandwagon.RPC.Net.send.onreadystatechange: 702482212271832: completed, status = 201

I wondering if the argument name has changed or something?

David McNamara [:mackers]

Assignee

Comment 6

•

15 years ago

Extension is playing fine. Looks like an API bug.

Passing to lorchard.

Assignee: dave → lorchard

Les Orchard [:lorchard]

Comment 7

•

15 years ago

I think I've got a fix.  Accidentally jumped the gun a bit with git-svn and checked it in as r24555, so no r? this time I guess.

But, for future API issues, can you file a separate bug (new, assigned to me) as a blocker for the extension bug?  It makes tracking tasks, patches, and reviews a lot easier.

Assignee: lorchard → dave

Brian King [:kinger]

Reporter

Comment 8

•

15 years ago

(In reply to comment #7)
> I think I've got a fix.  Accidentally jumped the gun a bit with git-svn and
> checked it in as r24555, so no r? this time I guess.

Works for me now.

> But, for future API issues, can you file a separate bug (new, assigned to me)
> as a blocker for the extension bug?  It makes tracking tasks, patches, and
> reviews a lot easier.

Ok, will do.

Status: NEW → RESOLVED

Closed: 15 years ago

Resolution: --- → FIXED

Carsten Book [:Tomcat]

Comment 9

•

15 years ago

verified

Status: RESOLVED → VERIFIED

Justin Scott [:fligtar]

Updated

•

14 years ago

Component: Collections → Collector Extension

Reed Loden [:reed]

Updated

•

14 years ago

QA Contact: collections → collector-extension

Nobody; OK to take it and work on it

Updated

•

8 years ago

Product: addons.mozilla.org → addons.mozilla.org Graveyard

Bugzilla

Quick Search

[Extension] Comments not appearing in published add-ons

Categories

(addons.mozilla.org Graveyard :: Collector Extension, defect)

Tracking

(Not tracked)

People

(Reporter: kinger, Assigned: mackers)

References

Details

Crash Data

Security

(public)

User Story

Description

Updated

Comment 1

Comment 2

Comment 3

Comment 4

Comment 5

Comment 6

Comment 7

Comment 8

Comment 9

Updated

Updated

Updated