TraceMonkey: Forcing platform features using NJ_FORCE_* causes the build to fail.

RESOLVED WONTFIX

Status

()

Core
JavaScript Engine
--
minor
RESOLVED WONTFIX
9 years ago
8 years ago

People

(Reporter: jbramley, Assigned: jbramley)

Tracking

Trunk
ARM
All
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
Created attachment 371680 [details] [diff] [review]
Fix feature detection code to be tolerant of forced values.

js/src/nanojit/avmplus.h allows NJ_FORCE_* to force certain configuration parameters. However, actually specifying one of these causes the build to fail because these values are written to in js/src/jstracer.cpp and they are declared as const when NJ_FORCE_* is in effect.

The attached patch fixes this by added pre-processor guards in js/src/jstracer.cpp.

Note: This patch builds on my patch for bug 487416.
Attachment #371680 - Flags: review?(vladimir)
(Assignee)

Updated

9 years ago
Status: NEW → ASSIGNED
(Assignee)

Updated

9 years ago
Keywords: checkin-needed
Should this land in tm or m-c?
Version: unspecified → Trunk
Whiteboard: [c-n: tracemonkey]
Land it in tracemonkey or wontfix it, don't just leave it in purgatory.
(Assignee)

Comment 3

9 years ago
Interesting. I thought this was pushed, but clearly nobody uses the NJ_FORCE flags else it would really have been pushed.

Now that the back-ends are merged, this get interesting. Tamarin doesn't do run-time detection, and doesn't use AvmCore::config for this stuff, so is this code only run by Trace Monkey? It's tempting to simply remove the NJ_FORCE support. We can now use lirasm to test code-paths anyway, and will we ever want to produce a build of Trace Monkey that does not do run-time feature detection? I suppose not, but I'd rather hear that from someone who really knows rather than supposes.
Keywords: checkin-needed
Whiteboard: [c-n: tracemonkey]
These bugs are all part of a search I made for js bugs that are getting lost in
transit:

http://tinyurl.com/jsDeadEndBugs

They all have a review+'ed, non-obsoleted patch and are not marked
fixed-in-tracemonkey or checkin-needed but have not seen any activity in 300
days. Some of these got lost simply because the assignee/patch provider never
requested a checkin, or just because they were forgotten about.
grep tells me that NJ_FORCE_* doesn't exist any more.
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.