Closed
Bug 487452
Opened 15 years ago
Closed 15 years ago
Incorporate latest memory profiler changes from sandbox branch to redux
Categories
(Tamarin Graveyard :: Garbage Collection (mmGC), defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: rishah, Unassigned)
Details
Attachments
(1 file, 4 obsolete files)
|
25.83 KB,
patch
|
treilly
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.0.5) Gecko/2008120121 Firefox/3.0.5 Build Identifier: Bug to move latest profiler changes made by Tommy from the sandbox build to tamarin redux. Reproducible: Always
|
Reporter | |
Comment 1•15 years ago
|
||
Attachment #372746 -
Flags: review?(treilly)
|
||
Updated•15 years ago
|
Attachment #372746 -
Flags: review?(treilly) → review-
|
|
||
Comment 2•15 years ago
|
||
Comment on attachment 372746 [details] [diff] [review] [v1] patch I'm review - my own changes! What a punk! Anyways I think changing heapAlloc to heap->InternalAlloc is wrong. Basically, they should remain heapAlloc but all calls from GC::AllocBlock* want to use GCHeap::InternalAlloc but all other callers of GC::heapAlloc want GCHeap::Alloc.
|
|
Reporter | |
Comment 3•15 years ago
|
||
Suggested changes made. I assume that the changes from Alloc -> InternalAlloc in FixedMalloc/FixedAlloc.cpp are fine.
Attachment #372746 -
Attachment is obsolete: true
Attachment #373034 -
Flags: review?(treilly)
|
|
Reporter | |
Comment 4•15 years ago
|
||
Attachment #373034 -
Attachment is obsolete: true
Attachment #373036 -
Flags: review?(treilly)
Attachment #373034 -
Flags: review?(treilly)
|
|
Reporter | |
Comment 5•15 years ago
|
||
Also, is InternalFree call inside GC::FreeBlock correct. FYI, DM has the above errors if that matters at all.
|
|
||
Comment 6•15 years ago
|
||
Comment on attachment 373036 [details] [diff] [review] [v2.1] patch I'll make the changes in DM so you can see what I mean
Attachment #373036 -
Flags: review?(treilly) → review-
|
|
Reporter | |
Comment 7•15 years ago
|
||
Includes latest changes from DM.
Attachment #373145 -
Flags: review?(treilly)
|
|
||
Comment 8•15 years ago
|
||
Comment on attachment 373145 [details] [diff] [review] [v3] patch Can you rebase the patch to the tip, looking at SetMemType and not seeing my changes from yesterday.
|
|
||
Updated•15 years ago
|
Attachment #373145 -
Flags: review?(treilly) → review-
|
|
Reporter | |
Comment 9•15 years ago
|
||
v3 patch based off redux tip.
Attachment #373036 -
Attachment is obsolete: true
Attachment #373145 -
Attachment is obsolete: true
Attachment #373153 -
Flags: review?(treilly)
|
|
||
Updated•15 years ago
|
Attachment #373153 -
Flags: review?(treilly) → review+
|
|
Reporter | |
Comment 10•15 years ago
|
||
changeset 1761 8e0de35a8b7e
Status: UNCONFIRMED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
||
Updated•15 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•