Closed
Bug 487531
Opened 17 years ago
Closed 17 years ago
Assertion failure running Dromaeo benchmarks: !_fragment->vmprivate && ti && cx->fp->regs->pc == (jsbytecode*)_fragment->ip, at /home/jimb/mc/in/js/src/jstracer.cpp:1223
Categories
(Core :: JavaScript Engine, defect, P1)
Tracking
()
VERIFIED
FIXED
mozilla1.9.1b4
People
(Reporter: jimb, Assigned: gal)
References
()
Details
(Keywords: verified1.9.1, Whiteboard: fixed-in-tracemonkey)
Attachments
(1 file)
|
1.04 KB,
patch
|
graydon
:
review+
|
Details | Diff | Splinter Review |
In TM changeset 2dd9a5df7cb4, visiting the above URL and clicking "Run" yields the following assertion:
Assertion failure: !_fragment->vmprivate && ti && cx->fp->regs->pc == (jsbytecode*)_fragment->ip, at /home/jimb/mc/in/js/src/jstracer.cpp:1223
|
Reporter | |
Updated•17 years ago
|
Summary: Assertion failure running Dromaeo benchmarks: → Assertion failure running Dromaeo benchmarks: !_fragment->vmprivate && ti && cx->fp->regs->pc == (jsbytecode*)_fragment->ip, at /home/jimb/mc/in/js/src/jstracer.cpp:1223
|
Assignee | |
Updated•17 years ago
|
Assignee: general → gal
|
|
Assignee | |
Comment 2•17 years ago
|
||
Confirmed with tip.
|
|
Assignee | |
Comment 3•17 years ago
|
||
Fixed. Testing.
|
|
Assignee | |
Comment 4•17 years ago
|
||
This is probably mostly cosmetic. I don't think we actually read or rely on branch fragment's ip. Anyway, should still fix. Making this p1 since it hits asserts in debug builds.
Assignee: general → gal
Attachment #371763 -
Flags: review?(graydon)
|
|
Assignee | |
Updated•17 years ago
|
Flags: blocking1.9.1?
Priority: -- → P1
Target Milestone: --- → mozilla1.9.1b4
|
||
Comment 5•17 years ago
|
||
covered by ecma/Date/15.9.5.10-7.js in the browser at least.
Flags: in-testsuite+
|
||
Updated•17 years ago
|
Flags: blocking1.9.1? → blocking1.9.1+
|
|
Assignee | |
Comment 6•17 years ago
|
||
Review ping.
|
||
Updated•17 years ago
|
Attachment #371763 -
Flags: review?(graydon) → review+
|
|
||
Comment 7•17 years ago
|
||
Comment on attachment 371763 [details] [diff] [review]
patch
I'm a little nervous about fragments-with-null-code surviving a failed recording attempt, rather than just freeing them and nulling out anchor->target again. But if you think it's safe, I'll defer to your judgment here. Clearly the patch will fix the assert.
|
|
Assignee | |
Comment 8•17 years ago
|
||
Whiteboard: fixed-in-tracemonkey
|
|
||
Comment 9•17 years ago
|
||
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
|
|
||
Comment 10•17 years ago
|
||
Keywords: fixed1.9.1
|
|
||
Comment 11•17 years ago
|
||
v 1.9.1, 1.9.2
Status: RESOLVED → VERIFIED
Keywords: fixed1.9.1 → verified1.9.1
You need to log in
before you can comment on or make changes to this bug.
Description
•