487569 - command "insert" doesn't work in editor.

Status: RESOLVED INVALID

(Skywriter Graveyard :: Command Line, defect)

Description

[ohdarling88]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; zh-CN; rv:1.9.0.8) Gecko/2009032609 Firefox/3.0.8 (.NET CLR 3.5.30729)
Build Identifier: chageset 280eec4d2b02

in frontend/js/bespin/cmd/commands.js, command 'insert' used a undefined variable self.editor.cursorPosition, it can be fixed by replace it with 'getCursorPos()':
self.editor.model.insertChunk(self.editor.cursorPosition, text);
=>
self.editor.model.insertChunk(self.editor.getCursorPos(), text);

Reproducible: Always

Steps to Reproduce:
1. open a file
2. jump to command line
3. run command 'insert blabla'

Comment 1

[Gordon P. Hemsley [:GPHemsley]]

I'm confirming this, because it's a valid concern. The fix you suggested was committed in changeset 25bd449d3aa5.

However, that fix was incorrect, as model's insertChunk() is expecting modelPos, not cursor's pos. I've applied the correct fix in my repo, changeset 5f3a1c8a5240:
http://bitbucket.org/gphemsley/bespin/changeset/5f3a1c8a5240/

Comment 2

[Gordon P. Hemsley [:GPHemsley]]

This is a mass migration from Mozilla Labs :: Bespin to Bespin :: Command Line.

Comment 3

[Ben Galbraith]

gordon, was this fixed?

Comment 4

[Gordon P. Hemsley [:GPHemsley]]

Well, the changeset I mentioned in comment 1 was indeed pulled into tip at some point, but the 'insert' command does not appear to exist anymore.