487571 - add xpcshell tests for network offline and connection refused

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Robert Strong (they/them - no direct email)]

Attachment: patch rev1

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: patch rev2

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 380243 [details] [diff] [review]
patch rev2

Would be nice with a comment describing what those error codes are.

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

r=me with that fixed.

Comment 4

[Robert Strong (they/them - no direct email)]

Attachment: patch

Carrying forward review.

I changed the code so it instead uses
Components.results.NS_ERROR_DOCUMENT_NOT_CACHED
and
Components.results.NS_ERROR_CONNECTION_REFUSED

I also added dump statements for each test stating what is being tested... I've found that handy when troubleshooting tests.

Comment 5

[Robert Strong (they/them - no direct email)]

Pushed to mozilla-central
http://hg.mozilla.org/mozilla-central/rev/5604374b01e8

Comment 6

[Robert Strong (they/them - no direct email)]

Pushed to mozilla-1.9.1
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/6f042c1aaff9

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Since nothing has been turned the tree red we can mark this bug as verified on trunk and 1.9.1.