Closed Bug 487571 Opened 16 years ago Closed 16 years ago

add xpcshell tests for network offline and connection refused

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

VERIFIED FIXED
mozilla1.9.2a1

People

(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)

References

Details

(Keywords: verified1.9.1)

Attachments

(2 files, 1 obsolete file)

Attached patch patch rev1 (obsolete) — Splinter Review
No description provided.
Attachment #371816 - Flags: review?(jonas)
No longer blocks: 487346
Attached patch patch rev2Splinter Review
Attachment #371816 - Attachment is obsolete: true
Attachment #380243 - Flags: review?(jonas)
Attachment #371816 - Flags: review?(jonas)
Comment on attachment 380243 [details] [diff] [review] patch rev2 Would be nice with a comment describing what those error codes are.
Attachment #380243 - Flags: review?(jonas) → review+
Attached patch patchSplinter Review
Carrying forward review. I changed the code so it instead uses Components.results.NS_ERROR_DOCUMENT_NOT_CACHED and Components.results.NS_ERROR_CONNECTION_REFUSED I also added dump statements for each test stating what is being tested... I've found that handy when troubleshooting tests.
Attachment #384346 - Flags: review+
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Since nothing has been turned the tree red we can mark this bug as verified on trunk and 1.9.1.
Status: RESOLVED → VERIFIED
Target Milestone: --- → mozilla1.9.2a1
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: