Closed
Bug 487571
Opened 16 years ago
Closed 16 years ago
add xpcshell tests for network offline and connection refused
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
VERIFIED
FIXED
mozilla1.9.2a1
People
(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)
References
Details
(Keywords: verified1.9.1)
Attachments
(2 files, 1 obsolete file)
3.44 KB,
patch
|
sicking
:
review+
|
Details | Diff | Splinter Review |
3.67 KB,
patch
|
robert.strong.bugs
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #371816 -
Flags: review?(jonas)
![]() |
Assignee | |
Comment 1•16 years ago
|
||
Attachment #371816 -
Attachment is obsolete: true
Attachment #380243 -
Flags: review?(jonas)
Attachment #371816 -
Flags: review?(jonas)
Comment on attachment 380243 [details] [diff] [review]
patch rev2
Would be nice with a comment describing what those error codes are.
Attachment #380243 -
Flags: review?(jonas) → review+
r=me with that fixed.
![]() |
Assignee | |
Comment 4•16 years ago
|
||
Carrying forward review.
I changed the code so it instead uses
Components.results.NS_ERROR_DOCUMENT_NOT_CACHED
and
Components.results.NS_ERROR_CONNECTION_REFUSED
I also added dump statements for each test stating what is being tested... I've found that handy when troubleshooting tests.
Attachment #384346 -
Flags: review+
![]() |
Assignee | |
Comment 5•16 years ago
|
||
Pushed to mozilla-central
http://hg.mozilla.org/mozilla-central/rev/5604374b01e8
![]() |
Assignee | |
Updated•16 years ago
|
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
![]() |
Assignee | |
Comment 6•16 years ago
|
||
Pushed to mozilla-1.9.1
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/6f042c1aaff9
Flags: in-testsuite+
Keywords: fixed1.9.1
Comment 7•16 years ago
|
||
Since nothing has been turned the tree red we can mark this bug as verified on trunk and 1.9.1.
Status: RESOLVED → VERIFIED
Keywords: fixed1.9.1 → verified1.9.1
Target Milestone: --- → mozilla1.9.2a1
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•