TraceMonkey: Don't use the ARM MOVW/MOVT instructions to write to the PC.

RESOLVED FIXED

Status

()

--
minor
RESOLVED FIXED
10 years ago
9 years ago

People

(Reporter: jbramley, Assigned: jbramley)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

10 years ago
Created attachment 371833 [details] [diff] [review]
Ensure that MOV(W|T) are not used to write to the PC.

Using MOVW/MOVT to write to the PC will not work as it will be written in two stages.

The attached patch fixes this so that the PC is never written in this way.

This bug has priority "minor" because LD32_nochk is never used to load into the PC (yet).
Attachment #371833 - Flags: review?(vladimir)
(Assignee)

Comment 1

10 years ago
Created attachment 371834 [details] [diff] [review]
Use the new config item name.

Actually, that patch won't apply on top of my patch for better processor detection. The new patch should apply on top of the patch for bug 487416.
Attachment #371833 - Attachment is obsolete: true
Attachment #371834 - Flags: review?(vladimir)
Attachment #371833 - Flags: review?(vladimir)
(Assignee)

Updated

10 years ago
Depends on: 487416
(Assignee)

Comment 2

10 years ago
Created attachment 371836 [details] [diff] [review]
Don't use MOV(W|T) to write to PC. Uses "config.thumb2" rather than "config.v6t2".

Previous patch didn't apply cleanly, so here is a replacement.
Attachment #371834 - Attachment is obsolete: true
Attachment #371836 - Flags: review?(vladimir)
Attachment #371834 - Flags: review?(vladimir)
(Assignee)

Updated

10 years ago
Whiteboard: fixed-in-tracemonkey

Comment 3

9 years ago
http://hg.mozilla.org/mozilla-central/rev/532a8d5d4685
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.