487669 - Better faster annotate left out the id on line numbers, so links with anchors don't scroll

Status: RESOLVED FIXED

(Developer Services :: Mercurial: hg.mozilla.org, defect)

Description

[Phil Ringnalda (:philor)]

STR:
1. Crash repeatedly
2. ctrl+click several of the source links in http://crash-stats.mozilla.com/report/index/3bf46c00-7570-4fac-ba93-12aea2090409
3. Visit each tab, wondering why you are at the top of the file instead of scrolled to a particular line

Looks like the bug 459823 changeover just forgot to bring along the |id="#lineid#"| on |<a class="codeline" href="##lineid#"|.

Comment 1

[Phil Ringnalda (:philor)]

Attachment: Fix v.1

Untested, because once I try your instructions (a la bug 459823 comment 16) I always remember that they don't actually work, but I always forget what you have to do instead to make it work.

Comment 2

[(not currently active) Ted Mielczarek]

http://armenzg.blogspot.com/2008/12/setup-your-own-hg-local-repo-with.html has good directions. Should put that on a wiki page somewhere.

Comment 3

[Phil Ringnalda (:philor)]

Good, but a touch excessive for "I just want to tweak a template a tiny bit": the only two things missing from your instructions if you don't need pushlog are

clone http://hg.mozilla.org/users/bsmedberg_mozilla.com/hgpoller/

in mozilla-central/.hg/hgrc include
[extensions]
buglink = {path to hgpoller clone}/buglink.py

Comment 4

[Phil Ringnalda (:philor)]

http://hg.mozilla.org/hg_templates/rev/f51076b127ba

Comment 5

[Gregory Szorc [:gps]]

https://hg.mozilla.org/hgcustom/version-control-tools/rev/ba10f09ab622