Closed Bug 487719 Opened 15 years ago Closed 15 years ago

video controls should use addEventListener instead of oncommand

Categories

(Toolkit :: Video/Audio Controls, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9.2a1

People

(Reporter: Dolske, Assigned: Dolske)

Details

(Keywords: fixed1.9.1)

Attachments

(1 file)

Attached patch Patch v.1Splinter Review
mrbkap needs this for some coming wrapper changes, and I think I like having all the addEventListener stuff in one place anyway.

This patch is on top of the patches for bug 475318 and bug 475317
Attachment #371978 - Flags: review?(gavin.sharp)
Attachment #371978 - Flags: review?(gavin.sharp) → review+
Attachment #371978 - Flags: approval1.9.1?
Pushed http://hg.mozilla.org/mozilla-central/rev/dde29bfff639
Assignee: nobody → dolske
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Whiteboard: [needs 191 landing]
Target Milestone: --- → mozilla1.9.2a1
Backed out (as part of the bug 475318 backout)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Whiteboard: [needs 191 landing]
Pushed http://hg.mozilla.org/mozilla-central/rev/7e088abcac55

Moving the mouseover/mouseout changes to bug 475317, so that this can land now for mrbkap.
Status: REOPENED → RESOLVED
Closed: 15 years ago15 years ago
Resolution: --- → FIXED
Whiteboard: [needs 1.9.1 landing]
Comment on attachment 371978 [details] [diff] [review]
Patch v.1

>             var self = this;
Given the number of times it's used, I would have gone for var Utils = this.Utils; instead.
Comment on attachment 371978 [details] [diff] [review]
Patch v.1

a191=beltzner
Attachment #371978 - Flags: approval1.9.1? → approval1.9.1+
Pushed to 191: http://hg.mozilla.org/releases/mozilla-1.9.1/rev/09761b41ddc1
Keywords: fixed1.9.1
Whiteboard: [needs 1.9.1 landing]
Component: Video/Audio → Video/Audio Controls
Product: Core → Toolkit
QA Contact: video.audio → video.audio
Version: Trunk → unspecified
You need to log in before you can comment on or make changes to this bug.