Closed Bug 487739 Opened 13 years ago Closed 13 years ago

places ifdef checks MACOSX instead of XP_MACOSX

Categories

(Firefox :: Bookmarks & History, defect)

All
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: jaas, Assigned: jaas)

Details

Attachments

(1 file)

browser/components/places/content/places.xul
298 #ifdef MACOSX
299                       label="&view.detailsMacOSX.label;"
300 #else
301                       label="&view.details.label;"
302 #endif

Probably want XP_MACOSX there.
yes thanks, luckily that code is commented out.
Attached patch fix v1.0Splinter Review
Attachment #374510 - Flags: review?
Assignee: nobody → joshmoz
Attachment #374510 - Flags: review? → review?(mconnor)
Attachment #374510 - Flags: review?(mconnor) → review+
pushed to mozilla-central

http://hg.mozilla.org/mozilla-central/rev/b552b1ef8aa0
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.