487745 - Search engines can't be downloaded after checking fancy new checkbox

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect, P1)

Description

[Wil Clouser [:clouserw]]

1) Load https://addons.mozilla.org/en-US/firefox/addon/11234
2) Check the box
3) Click "Add to firefox"

We need the javascript to add "?confirmed" to the end of the URL so it bypasses the login requirement.

Also, there is no way to add priority to a bug when it's first being filed. :(

Comment 1

[Wil Clouser [:clouserw]]

fix committed in r24378 for testing.

Comment 2

[krupa raj[:krupa]]

Attachment: search error

Unable to add an experimental search tool.Fails with error message(see screenshot)

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

For reference/testing, this means that the URL of my test add-on at https://preview.addons.mozilla.org/en-US/firefox/addon/9602, https://preview.addons.mozilla.org/en-US/firefox/downloads/file/41118/a9-20090308.xml, should end in "?confirmed" in order to install, right?

Comment 4

[krupa raj[:krupa]]

Attachment: installation error

For one search tool,I was able to proceed to install after which I got this error message.

Comment 5

[Wil Clouser [:clouserw]]

(In reply to comment #3)
> For reference/testing, this means that the URL of my test add-on at
> https://preview.addons.mozilla.org/en-US/firefox/addon/9602,
> https://preview.addons.mozilla.org/en-US/firefox/downloads/file/41118/a9-20090308.xml,
> should end in "?confirmed" in order to install, right?

In theory, yeah, although it doesn't seem to work with 9596.  I get redirected to a login page.

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Live HTTP Headers of a failed download

Looks like we're still doing the login?to= stuff:

GET /en-US/firefox/users/login?to=downloads%2Ffile%2F41078%2Fyellow_pages-20081113.xml&m=1 HTTP/1.1

Comment 7

[Wil Clouser [:clouserw]]

Attachment: fix for search engines

This patch should fix the problem.  in r24411 for testing

Comment 8

[Wil Clouser [:clouserw]]

A fix for search engines with EULAs in r24412.  Consider that part of the r?

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

Testcase for preview: https://preview.addons.mozilla.org/en-US/firefox/addon/9602/

Comment 10

[Stephen Donner [:stephend] Not actively reading bugmail]

This looks good, sans the bogus search-engine files, such as https://preview.addons.mozilla.org/en-US/firefox/addon/9541, that don't work (pre-existing) because their URLs are malformed.

Comment 11

[Alex Buchanan [:abuchanan]]

Comment on attachment 372647 [details] [diff] [review]
fix for search engines

code looks fine, and testing on preview hasn't thrown any red flags

Comment 12

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on both regular (i.e. non-EULA) search engines (https://addons.mozilla.org/en-US/firefox/addon/11234 from comment 0), as well as:

"milw0rm search plugin" 20090408 https://addons.mozilla.org/en-US/firefox/addon/11374