487765 - qcms failed to compile on Solaris

Status: RESOLVED FIXED

(Core :: Graphics: Color Management, defect)

Description

[Ginn Chen]

There are 2 problems.

1) LITTLE_ENDIAN/BIG_ENDIAN is not defined
2) int_types.h defines uintptr_t as unsigned int, but prtypes.h defines PRUptrdiff as unsinged long.
so typedef PRUptrdiff uintptr_t is an error.
int8_t is similar, PRInt8 is signed char, but int_types.h defines int8_t as char.

Comment 1

[Ginn Chen]

I saw we have 487566, 487754.

I think we should fix them all together.
For problem 1)
(include prtypes.h)
#ifdef IS_LITTLE_ENDIAN
#define LITTLE_ENDIAN
#endif

#ifdef IS_BIG_ENDIAN
#define BIG_ENDIAN
#endif

For problem 2)
If the system has <inttypes.h> or <stdint.h> why would we redefine them from PR* ?

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Attachment: Fix build problems on solaris

Does this patch fix it?

Comment 3

[Ginn Chen]

Attachment: patch

I changed your patch a bit to make it work.

Comment 4

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 372555 [details] [diff] [review]
patch

Looks good to me.

Comment 5

[Johnathan Nightingale [:johnath]]

http://hg.mozilla.org/mozilla-central/rev/6a928bad6136

Comment 6

[Johnathan Nightingale [:johnath]]

Attachment: As checked in