5 sort operations required by FindVisits selectStatement

RESOLVED FIXED in mozilla1.9.2a1

Status

()

RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: mak, Assigned: mak)

Tracking

({fixed1.9.1, perf})

Trunk
mozilla1.9.2a1
fixed1.9.1, perf
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

10 years ago
with bug 481261 this query will warn due to the fact it cannot use an index to sort.
(Assignee)

Comment 1

10 years ago
Created attachment 373244 [details] [diff] [review]
patch v1.0

dunno what i was thinking when i wrote the original query, could be sqlite has changed a lot lately, my new local tests are quite different.
This does not warn and is about 10x faster, hard to believe, i know.
Assignee: nobody → mak77
Status: NEW → ASSIGNED
Attachment #373244 - Flags: review?(sdwilsh)
Comment on attachment 373244 [details] [diff] [review]
patch v1.0

r=sdwilsh
Attachment #373244 - Flags: review?(sdwilsh) → review+
(Assignee)

Comment 3

10 years ago
http://hg.mozilla.org/mozilla-central/rev/4ca7c96126b0
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
(Assignee)

Comment 4

10 years ago
Comment on attachment 373244 [details] [diff] [review]
patch v1.0

asking approval for a quite more efficient query, the query is used to find visits to expire.
Time of the query is reduced from about 200ms to about 20ms. Can potentially reduce TShutdown.
Attachment #373244 - Flags: approval1.9.1?
And reduce CPU usage during idle expiration too!
Attachment #373244 - Flags: approval1.9.1? → approval1.9.1+
You need to log in before you can comment on or make changes to this bug.