Closed Bug 487781 Opened 12 years ago Closed 12 years ago

5 sort operations required by FindVisits selectStatement

Categories

(Toolkit :: Places, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9.2a1

People

(Reporter: mak, Assigned: mak)

References

Details

(Keywords: fixed1.9.1, perf)

Attachments

(1 file)

with bug 481261 this query will warn due to the fact it cannot use an index to sort.
Attached patch patch v1.0Splinter Review
dunno what i was thinking when i wrote the original query, could be sqlite has changed a lot lately, my new local tests are quite different.
This does not warn and is about 10x faster, hard to believe, i know.
Assignee: nobody → mak77
Status: NEW → ASSIGNED
Attachment #373244 - Flags: review?(sdwilsh)
Comment on attachment 373244 [details] [diff] [review]
patch v1.0

r=sdwilsh
Attachment #373244 - Flags: review?(sdwilsh) → review+
http://hg.mozilla.org/mozilla-central/rev/4ca7c96126b0
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
Comment on attachment 373244 [details] [diff] [review]
patch v1.0

asking approval for a quite more efficient query, the query is used to find visits to expire.
Time of the query is reduced from about 200ms to about 20ms. Can potentially reduce TShutdown.
Attachment #373244 - Flags: approval1.9.1?
And reduce CPU usage during idle expiration too!
Attachment #373244 - Flags: approval1.9.1? → approval1.9.1+
You need to log in before you can comment on or make changes to this bug.