487823 - mochitest-browser-chrome: hang/timeout ("1200 seconds without output") on/after alltabslistener

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Daniel Holbert [:dholbert]]

Two out of the past five Linux mozilla-central unit test cycles have been orange, with a hang/timeout (1200 seconds without output) in mochitest-browser-chrome.

Both of these oranges have output like the following:
======================
Finished tests from alltabslistener.js
*** can move shortcut id?
*** can move shortcut node?
*** can move shortcut id?
*** can move shortcut node?
*** can move shortcut id?
*** can move shortcut node?
*** can move shortcut id?
*** can move shortcut node?
invalid new default button: , assuming: none
invalid new default button: , assuming: none

command timed out: 1200 seconds without output, killing pid 13343
process killed by signal 9
program finished with exit code -1
elapsedTime=1231.010352
TinderboxPrint: mochitest-browser-chrome<br/><em class="testfail">T-FAIL</em>
buildbot.slave.commands.TimeoutError: command timed out: 1200 seconds without output, killing pid 13343
======================

I'm filing this bug in the Places component, because the "can move shortcut node?" text (before the timeout/hang) is from browser/components/places/tests/browser/browser_423515.js

The failure logs are:
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1239373268.1239379755.22890.gz
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1239377278.1239386494.32740.gz

Comment 1

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

if that can help, also other crashes and issues stop there, even if i never found a direct relation with that specific test.

invalid new default button: , assuming: none
this is relative to bookmarksProperties.xul, could be an hang on browser_bookmarksProperties.js... that could happen if we lose focus.

Comment 2

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

taking, i want to try if i can remove all focus requirements from the above test.

Comment 3

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Attachment: patch v1.0

This should make the test a bit more solid since i've removed some focus and systhesize call, but mainly will detect situations where we could hang due to focus issues, and annotates every focus call with a dump to easily find the point where we hang in case it should still happen due to this test.

Comment 4

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Comment on attachment 374038 [details] [diff] [review]
patch v1.0

still something to fix, and adw reported an hang (he also said old version was not hanging for him).
Btw, needs new patch.

Comment 5

[Serge Gautherie (:sgautherie)]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1240942338.1240952556.11319.gz
WINNT 5.2 mozilla-central unit test on 2009/04/28 11:12:18
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1240949538.1240955358.14534.gz
WINNT 5.2 mozilla-central unit test on 2009/04/28 13:12:18

Comment 6

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Attachment: patch v1.1

Drew, could you please check how is this working on your side?

Comment 7

[Drew Willcoxon :adw]

Works here.

Comment 8

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Comment on attachment 374999 [details] [diff] [review]
patch v1.1

thanks, going for review

Comment 9

[Drew Willcoxon :adw]

Comment on attachment 374999 [details] [diff] [review]
patch v1.1

>+    var popupListener = {
>+      handleEvent: function(aEvent) {
>+        switch (aEvent.type) {
>+          case "popuphidden":
>+            // Everything worked fine, we can stop observing the window.
>+            ww.unregisterNotification(windowObserver);
>+            tagsField.popup.removeEventListener("popuphidden", this, true);
>+            self.window.document.documentElement.cancelDialog();
>+            self.finish();
>+            break;
>+          case "popupshown":
>+            ok(true, "popupshown");

That's interesting.  ok(true, str) is basically a dump statement formatted like a test result, isn't it?

r=adw

Comment 10

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Attachment: patch v1.2

cleaned up the 2 useless test-dumps.

Comment 11

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

let's see if this helps.
http://hg.mozilla.org/mozilla-central/rev/e134b869d01c

Comment 12

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/d8be8d56fdd7

Comment 13

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv