487831 - Remove completely unused frame methods (Get|Set)WasCollapsed

Status: RESOLVED FIXED

(Core :: Layout: Block and Inline, enhancement, P4)

Description

[Zack Weinberg (:zwol)]

Attachment: patch

The frame methods GetWasCollapsed and SetWasCollapsed (defined on nsFrame, nsBox, nsBoxFrame, and nsLeafBoxFrame) are completely unused.  This patch removes them and the data members (a nsBoxLayoutMetrics member and a nsBox state bit) that support them.

(I noticed this while trying to find a sane fix for bug 486065.)

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 372087 [details] [diff] [review]
patch

>-#define NS_STATE_IS_COLLAPSED            0x10000000
>+//#define NS_STATE_IS_COLLAPSED            0x10000000  not used anymore

Just remove the line; don't comment it out.  (If you want you can leave a comment that 0x10000000 is unused, but don't say what it used to be.)

r+sr=dbaron with that

Comment 2

[Zack Weinberg (:zwol)]

Attachment: v2 with dead flag totally removed

Here.  I am leaving "0x10000000 not used anymore" because there are several other commented-out values in this file ("moved to other.h")...

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

http://hg.mozilla.org/mozilla-central/rev/7030a020fed0