Closed
Bug 487831
Opened 15 years ago
Closed 15 years ago
Remove completely unused frame methods (Get|Set)WasCollapsed
Categories
(Core :: Layout: Block and Inline, enhancement, P4)
Core
Layout: Block and Inline
Tracking
()
RESOLVED
FIXED
mozilla1.9.2a1
People
(Reporter: zwol, Assigned: zwol)
Details
Attachments
(1 file, 1 obsolete file)
8.35 KB,
patch
|
zwol
:
review+
zwol
:
superreview+
|
Details | Diff | Splinter Review |
The frame methods GetWasCollapsed and SetWasCollapsed (defined on nsFrame, nsBox, nsBoxFrame, and nsLeafBoxFrame) are completely unused. This patch removes them and the data members (a nsBoxLayoutMetrics member and a nsBox state bit) that support them. (I noticed this while trying to find a sane fix for bug 486065.)
Attachment #372087 -
Flags: superreview?(dbaron)
Attachment #372087 -
Flags: review?(dbaron)
Comment on attachment 372087 [details] [diff] [review] patch >-#define NS_STATE_IS_COLLAPSED 0x10000000 >+//#define NS_STATE_IS_COLLAPSED 0x10000000 not used anymore Just remove the line; don't comment it out. (If you want you can leave a comment that 0x10000000 is unused, but don't say what it used to be.) r+sr=dbaron with that
Attachment #372087 -
Flags: superreview?(dbaron)
Attachment #372087 -
Flags: superreview+
Attachment #372087 -
Flags: review?(dbaron)
Attachment #372087 -
Flags: review+
Assignee | ||
Comment 2•15 years ago
|
||
Here. I am leaving "0x10000000 not used anymore" because there are several other commented-out values in this file ("moved to other.h")...
Attachment #372087 -
Attachment is obsolete: true
Attachment #372091 -
Flags: superreview+
Attachment #372091 -
Flags: review+
Assignee | ||
Updated•15 years ago
|
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/7030a020fed0
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Keywords: checkin-needed
Priority: -- → P4
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
You need to log in
before you can comment on or make changes to this bug.
Description
•