Created attachment 372087 [details] [diff] [review] patch The frame methods GetWasCollapsed and SetWasCollapsed (defined on nsFrame, nsBox, nsBoxFrame, and nsLeafBoxFrame) are completely unused. This patch removes them and the data members (a nsBoxLayoutMetrics member and a nsBox state bit) that support them. (I noticed this while trying to find a sane fix for bug 486065.)
Comment on attachment 372087 [details] [diff] [review] patch >-#define NS_STATE_IS_COLLAPSED 0x10000000 >+//#define NS_STATE_IS_COLLAPSED 0x10000000 not used anymore Just remove the line; don't comment it out. (If you want you can leave a comment that 0x10000000 is unused, but don't say what it used to be.) r+sr=dbaron with that
Created attachment 372091 [details] [diff] [review] v2 with dead flag totally removed Here. I am leaving "0x10000000 not used anymore" because there are several other commented-out values in this file ("moved to other.h")...
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Priority: -- → P4
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
You need to log in before you can comment on or make changes to this bug.