487900 - Enable SSE2 code for x86_64 in qcms

Status: RESOLVED FIXED

(Core :: Graphics: Color Management, defect)

Description

[Makoto Kato [:m_kato]]

Attachment: patch v1

SSE2 code in qcms is only for IA32.  We should enable it for x86_64 platform.

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 372192 [details] [diff] [review]
patch v1

Why use intrinsics instead of inline assembly on x86-64? How does the code compare to inline assembly version?

Comment 2

[Bobby Holley (:bholley)]

I believe the inline assembly isn't available for x86_64 - Makoto knows more about it than I do though.

Comment 3

[Makoto Kato [:m_kato]]

(In reply to comment #1)
> (From update of attachment 372192 [details] [diff] [review])
> Why use intrinsics instead of inline assembly on x86-64? How does the code
> compare to inline assembly version?

Thanks, Bobby.  MSVC with x64 doesn't support inline assembler.  See http://msdn.microsoft.com/en-us/library/wbk4z78b%28VS.80%29.aspx.

Of course, I tests this patch, the result is same.  This patch re-writes same code by SSE2 built-in functions for Windows x64 instead of inline assembler.

Also, this patch uses inline assembler if gcc with x86_64 such as Linux x86_64.  And since x86_64 always support SSE2, it doesn't check whether supporting SSE2 or not.

Comment 4

[Makoto Kato [:m_kato]]

Ccing Jeff.  I commented for your question by comment #3.  Could you review again?

Comment 5

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 372192 [details] [diff] [review]
patch v1

In that case, this looks fine.

Comment 6

[Makoto Kato [:m_kato]]

landed
http://hg.mozilla.org/mozilla-central/rev/9a76e03c8ee6