Closed Bug 487900 Opened 12 years ago Closed 12 years ago

Enable SSE2 code for x86_64 in qcms

Categories

(Core :: GFX: Color Management, defect)

x86_64
All
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: m_kato, Assigned: m_kato)

Details

Attachments

(1 file)

Attached patch patch v1Splinter Review
SSE2 code in qcms is only for IA32.  We should enable it for x86_64 platform.
Attachment #372192 - Flags: review?(vladimir)
Attachment #372192 - Flags: review?(vladimir) → review?(jmuizelaar)
Comment on attachment 372192 [details] [diff] [review]
patch v1

Why use intrinsics instead of inline assembly on x86-64? How does the code compare to inline assembly version?
Attachment #372192 - Flags: review?(jmuizelaar) → review-
I believe the inline assembly isn't available for x86_64 - Makoto knows more about it than I do though.
(In reply to comment #1)
> (From update of attachment 372192 [details] [diff] [review])
> Why use intrinsics instead of inline assembly on x86-64? How does the code
> compare to inline assembly version?

Thanks, Bobby.  MSVC with x64 doesn't support inline assembler.  See http://msdn.microsoft.com/en-us/library/wbk4z78b%28VS.80%29.aspx.

Of course, I tests this patch, the result is same.  This patch re-writes same code by SSE2 built-in functions for Windows x64 instead of inline assembler.

Also, this patch uses inline assembler if gcc with x86_64 such as Linux x86_64.  And since x86_64 always support SSE2, it doesn't check whether supporting SSE2 or not.
Ccing Jeff.  I commented for your question by comment #3.  Could you review again?
Comment on attachment 372192 [details] [diff] [review]
patch v1

In that case, this looks fine.
Attachment #372192 - Flags: review- → review+
landed
http://hg.mozilla.org/mozilla-central/rev/9a76e03c8ee6
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.