Closed
Bug 488068
Opened 16 years ago
Closed 16 years ago
ImmReleaseContext should be called for opened HIMC
Categories
(Core :: Widget: Win32, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9.2a1
People
(Reporter: ashie, Assigned: ashie)
Details
(Keywords: mobile)
Attachments
(1 file)
|
1.63 KB,
patch
|
dougt
:
review+
pavlov
:
superreview+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.0; ja; rv:1.9.0.4) Gecko/2008102920 Firefox/3.0.4 (.NET CLR 3.5.30729)
Build Identifier:
ImmReleaseContext() should be called for opened HIMC
http://msdn.microsoft.com/en-us/library/aa913790.aspx
But there are some places it isn't called on WinCE specific code.
https://hg.mozilla.org/mozilla-central/file/07599e2b0941/widget/src/windows/nsWindow.cpp#l4636
I'll attach a patch.
Reproducible: Always
|
Assignee | |
Updated•16 years ago
|
OS: Other → Windows Mobile 6 Professional
Product: Fennec → Core
Hardware: Other → ARM
|
|
Assignee | |
Comment 1•16 years ago
|
||
A patch to plug leaked HIMC.
|
||
Updated•16 years ago
|
Attachment #372352 -
Flags: review?(bugmail)
|
||
Updated•16 years ago
|
Component: General → Widget: Win32
QA Contact: general → win32
|
||
Updated•16 years ago
|
Attachment #372352 -
Flags: review?(bugmail) → review?(doug.turner)
|
|
||
Comment 2•16 years ago
|
||
Comment on attachment 372352 [details] [diff] [review]
Plug leaked HIMC.
looks good to me, but Doug is a widget peer
|
||
Updated•16 years ago
|
Attachment #372352 -
Flags: superreview?(emaijala)
Attachment #372352 -
Flags: review?(doug.turner)
Attachment #372352 -
Flags: review+
|
||
Comment 3•16 years ago
|
||
Comment on attachment 372352 [details] [diff] [review]
Plug leaked HIMC.
Looks good, but I'm not a super-reviewer.
Attachment #372352 -
Flags: superreview?(emaijala)
|
|
||
Updated•16 years ago
|
Attachment #372352 -
Flags: superreview?(pavlov)
|
||
Updated•16 years ago
|
Attachment #372352 -
Flags: superreview?(pavlov) → superreview+
|
||
Updated•16 years ago
|
Keywords: checkin-needed
|
|
||
Updated•16 years ago
|
Assignee: nobody → ashie
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
|
||
Comment 4•16 years ago
|
||
Needs landing?
|
|
||
Comment 5•16 years ago
|
||
Yes, please.
|
||
Comment 6•16 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
You need to log in
before you can comment on or make changes to this bug.
Description
•