488070 - Clear Private Data doesn't clear extension-stored data

Status: VERIFIED WORKSFORME

(Firefox :: Private Browsing, defect)

Description

[Myk Melez [:myk] [@mykmelez]]

When a user configures Firefox to clear private data on shutdown (Preferences > Privacy > Always clear my private data when I close Firefox), it doesn't affect data stored by any extensions installed in the user's browser.

It shouldn't clear such data by default, but there should be an option to do so, given that extensions can store just as much private data as any native Firefox component.

Perhaps the Settings for Clearing History dialog (that lets you specify which private data to clear on shutdown) could include an option for clearing extension-stored data.  Then, if the user checked that option, Firefox would notify extensions via a "clear-extension-data-requested" notification or the like, and extensions that observed that notification would have the opportunity to clear the data they store.

Filing this in the Private Browsing component, although it isn't part of the new Private Browsing feature, as that's the most applicable component.  Perhaps that component should be renamed Privacy to encompass all privacy-related issues.

Comment 1

[(no longer active)]

What you want already exists: the browser:purge-session-history notification.  It is however up to extensions to handle that notification, though, because we can't reliably detect and clear all the data stored by an extension.

Resolving this as WFM.

Adding dev-doc-needed to make sure this gets documented on MDC.

Comment 2

[Myk Melez [:myk] [@mykmelez]]

Indeed. Thanks for the tip!

Comment 3

[Eric Shepherd [:sheppy]]

This notification is now mentioned here: https://developer.mozilla.org/En/Supporting_private_browsing_mode#Private_browsing_notifications

And I've added a section on private browsing notifications to the notification docs here:

https://developer.mozilla.org/En/Observer_Notifications

Comment 4

[Nochum Sossonko [:Natch]]

(In reply to comment #3)
> This notification is now mentioned here:
> https://developer.mozilla.org/En/Supporting_private_browsing_mode#Private_browsing_notifications
> 
> And I've added a section on private browsing notifications to the notification
> docs here:
> 
> https://developer.mozilla.org/En/Observer_Notifications

That notification has nothing to do with Private Browsing, it's a notification when the sanitizer clears _all_ history information, something Private Browsing does not do.

Also, AFAIK, this notification was there before 3.5...

Comment 5

[Nochum Sossonko [:Natch]]

http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/browser/base/content/sanitize.js&rev=1.2&root=/cvsroot#119

Added in bug 274712 AFAICT. So it seems it has been around since Aviary...

Comment 6

[Eric Shepherd [:sheppy]]

Seems like something that would have taken less time for you to fix in the docs yourself than reopen the bug and comment twice on, but I've fixed this now.