Closed Bug 488117 Opened 11 years ago Closed 11 years ago

Fix qcms and breakpad chunks of toolkit-makefiles.sh

Categories

(Toolkit Graveyard :: Build Config, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.9.2a1

People

(Reporter: philor, Assigned: philor)

References

()

Details

Attachments

(2 files)

Happened to have my build hang just after the output from Makefile creation the other day, which made me notice that qcms is wrong about where it lives, thinking that there would be a modules/qcms/Makefile.in instead of a gfx/qcms/, and the toolkit/crashreporter/google-breakpad/src/ chunk has one which doesn't exist (client/windows/), and is missing several more.
blanket r=me to fix stuff like this (if I didn't already grant it in the past).
Either you did or I was carrying over bsmedberg's ;)

I just needed to write myself a reminder to do this, and while I was deciding where to write it, Bugzilla leaped to mind.
This fixes the qcms problem.
Nope, you either want to do that plus remove the $MAKEFILES_qcms line from add_makefiles plus add it to the gfx block as gfx/qcms/Makefile (which is the prettier way), or just change that block to refer to gfx/qcms/Makefile.
http://hg.mozilla.org/mozilla-central/rev/b54a17f1d9c8 is the mislabeled checkin of Jeff's patch.
Jeff, can you take a look at this recent bug I logged, https://bugzilla.mozilla.org/show_bug.cgi?id=488785
http://hg.mozilla.org/mozilla-central/rev/56308aac106b
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.