488128 - Make translation box element available outside developer pages

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect, P2)

Description

[Fred Wenzel [:wenzel]]

For bug 480495, a translation box is needed in the users controller. Need to move the translation box element out of the dev pages, along with its specific JS and CSS.

Comment 1

[Fred Wenzel [:wenzel]]

Attachment: Make translation box a "non-dev" element

Pretty big patch but should be easy to read: I am moving the translation box out of the developer-only elements along with its specific CSS and JS code, then adjust the few places where translation boxes are used.

Thanks, Wil!

Comment 2

[Fred Wenzel [:wenzel]]

Attachment: Patch, rev. 2

Meh, the html-rtl patch caused major bit-rot here :(

Comment 3

[Wil Clouser [:clouserw]]

Comment on attachment 372556 [details] [diff] [review]
Patch, rev. 2

works with my testing

Comment 4

[Fred Wenzel [:wenzel]]

Thanks: r24479. (git rebase -i is teh awesome.)

QA: you can verify this by making sure the "translation boxes" in the dev cp still work.

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

Krupa and I looked at this, and tested:

* Adding (per section/global)/removing
** Empty additions correctly don't persist on submit
* Attempting to add twice (we correctly remove the locale from the select pulldown as you add it)

If we find additional bugs, we'll of course file.

Verified FIXED on https://preview.addons.mozilla.org/en-US/developers/addon/edit/9331/descriptions