488136 - Update "Get Firefox 3" to "Get Firefox 3.5" in product-details lib

Status: VERIFIED FIXED

(www.mozilla.org :: General, defect)

Description

[Steven Garrity [:sgarrity]]

It looks like the only reference to the major version number of Firefox in the product-details library is on line #357 of firefoxDetails.class.php:

 $options['download_title'] = array_key_exists('download_title', $options) ? $options['download_title'] : ___('Get Firefox 3');

Can you either update this (in trunk only, for now) to "Get Firefox 3.5", or should we re-work this so there are no version number references in product-details?

Comment 1

[Wil Clouser [:clouserw]]

It should be reworked but I don't have time right now.  It's 3.5 in r24370.

Comment 2

[Reed Loden [:reed]]

??? won't this break the current 3.0 website when we do our next release?

Comment 3

[Wil Clouser [:clouserw]]

Yep, didn't see the release was next week.  I've rolled it back.  Next easiest way to do this is to add this to the bottom of /en-US/includes/l10n/main.lang:

;Get Firefox 3
Get Firefox 3.5

Comment 4

[Steven Garrity [:sgarrity]]

(In reply to comment #3)
> Yep, didn't see the release was next week.  I've rolled it back.  Next easiest
> way to do this is to add this to the bottom of /en-US/includes/l10n/main.lang:

I've done this in trunk in r24397, we'll just have to be sure it doesn't get pushed to stage/production.

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED.