Closed Bug 488140 Opened 15 years ago Closed 15 years ago

rename the class in nsAutodialWinCE to nsAutodialWinCE.

Categories

(Core :: Networking, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: dougt, Assigned: dougt)

Details

(Keywords: fixed1.9.1)

Attachments

(1 file, 1 obsolete file)

stuart correctly points out that the class in nsAutodialWinCE has nothing to do with RAS any longer has should be renamed.

see https://bugzilla.mozilla.org/show_bug.cgi?id=486063
OS: Mac OS X → All
Hardware: x86 → All
Attached patch patch v.1 (obsolete) — Splinter Review
Attached patch patch v.2Splinter Review
Attachment #372414 - Attachment is obsolete: true
Attachment #372419 - Flags: superreview?(pavlov)
Attachment #372419 - Flags: review?(jduell.mcbugs)
Attachment #372419 - Flags: review?(jduell.mcbugs) → review+
Comment on attachment 372419 [details] [diff] [review]
patch v.2

No semantic changes, so obviously this should be fine.

I assume there's a reason why you didn't rename some of the various "RAS" types (such as tRASPHONEBOOKDLG).  No need to explain--just wanted to note that they haven't been "de-RASed", in case you missed it.
I didn't rename the "RAS" types because they really are talking about the windows "remote access service" apis.
Attachment #372419 - Flags: superreview?(pavlov) → superreview+
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Attachment #372419 - Flags: approval1.9.1? → approval1.9.1+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: