rename the class in nsAutodialWinCE to nsAutodialWinCE.

RESOLVED FIXED

Status

()

Core
Networking
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: dougt, Assigned: dougt)

Tracking

({fixed1.9.1})

Trunk
fixed1.9.1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

9.61 KB, patch
jduell
: review+
Stuart Parmenter
: superreview+
beltzner
: approval1.9.1+
Details | Diff | Splinter Review
(Assignee)

Description

9 years ago
stuart correctly points out that the class in nsAutodialWinCE has nothing to do with RAS any longer has should be renamed.

see https://bugzilla.mozilla.org/show_bug.cgi?id=486063
(Assignee)

Updated

9 years ago
OS: Mac OS X → All
Hardware: x86 → All
(Assignee)

Comment 1

9 years ago
Created attachment 372414 [details] [diff] [review]
patch v.1
(Assignee)

Comment 2

9 years ago
Created attachment 372419 [details] [diff] [review]
patch v.2
Attachment #372414 - Attachment is obsolete: true
(Assignee)

Updated

9 years ago
Attachment #372419 - Flags: superreview?(pavlov)
Attachment #372419 - Flags: review?(jduell.mcbugs)
Attachment #372419 - Flags: review?(jduell.mcbugs) → review+
Comment on attachment 372419 [details] [diff] [review]
patch v.2

No semantic changes, so obviously this should be fine.

I assume there's a reason why you didn't rename some of the various "RAS" types (such as tRASPHONEBOOKDLG).  No need to explain--just wanted to note that they haven't been "de-RASed", in case you missed it.
(Assignee)

Comment 4

9 years ago
I didn't rename the "RAS" types because they really are talking about the windows "remote access service" apis.

Updated

9 years ago
Attachment #372419 - Flags: superreview?(pavlov) → superreview+
(Assignee)

Updated

9 years ago
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Attachment #372419 - Flags: approval1.9.1? → approval1.9.1+
You need to log in before you can comment on or make changes to this bug.