Closed
Bug 488140
Opened 15 years ago
Closed 15 years ago
rename the class in nsAutodialWinCE to nsAutodialWinCE.
Categories
(Core :: Networking, defect)
Core
Networking
Tracking
()
RESOLVED
FIXED
People
(Reporter: dougt, Assigned: dougt)
Details
(Keywords: fixed1.9.1)
Attachments
(1 file, 1 obsolete file)
9.61 KB,
patch
|
jduell.mcbugs
:
review+
pavlov
:
superreview+
beltzner
:
approval1.9.1+
|
Details | Diff | Splinter Review |
stuart correctly points out that the class in nsAutodialWinCE has nothing to do with RAS any longer has should be renamed. see https://bugzilla.mozilla.org/show_bug.cgi?id=486063
Assignee | ||
Updated•15 years ago
|
OS: Mac OS X → All
Hardware: x86 → All
Assignee | ||
Comment 1•15 years ago
|
||
Assignee | ||
Comment 2•15 years ago
|
||
Attachment #372414 -
Attachment is obsolete: true
Assignee | ||
Updated•15 years ago
|
Attachment #372419 -
Flags: superreview?(pavlov)
Attachment #372419 -
Flags: review?(jduell.mcbugs)
Updated•15 years ago
|
Attachment #372419 -
Flags: review?(jduell.mcbugs) → review+
Comment 3•15 years ago
|
||
Comment on attachment 372419 [details] [diff] [review] patch v.2 No semantic changes, so obviously this should be fine. I assume there's a reason why you didn't rename some of the various "RAS" types (such as tRASPHONEBOOKDLG). No need to explain--just wanted to note that they haven't been "de-RASed", in case you missed it.
Assignee | ||
Comment 4•15 years ago
|
||
I didn't rename the "RAS" types because they really are talking about the windows "remote access service" apis.
Updated•15 years ago
|
Attachment #372419 -
Flags: superreview?(pavlov) → superreview+
Assignee | ||
Comment 5•15 years ago
|
||
Comment on attachment 372419 [details] [diff] [review] patch v.2 http://hg.mozilla.org/mozilla-central/rev/68d9acc70491
Attachment #372419 -
Flags: approval1.9.1?
Assignee | ||
Updated•15 years ago
|
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Updated•15 years ago
|
Attachment #372419 -
Flags: approval1.9.1? → approval1.9.1+
Comment 6•15 years ago
|
||
Comment on attachment 372419 [details] [diff] [review] patch v.2 a191=beltzner
Comment 7•15 years ago
|
||
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/dc0925f11ab1
Keywords: fixed1.9.1
You need to log in
before you can comment on or make changes to this bug.
Description
•