Status

defect
VERIFIED FIXED
10 years ago
3 years ago

People

(Reporter: lorchard, Assigned: wenzel)

Tracking

unspecified
BW-M5
Dependency tree / graph

Details

Attachments

(2 attachments)

Reporter

Description

10 years ago
We've got a placeholder for collection icons in place as of bug 487397, but a real end-to-end feature needs to be implemented for:

* accepting image uploads for collection icons
* hosting and serving uploaded collection icon images

We could stuff these into the database as blobs like addon icons, but this might be a good time to look at an alternative approach.  (eg. CDN, or at least a file system behind a static apache server somewhere.)
Assignee: nobody → fwenzel
Blocks: 456132
Reporter

Comment 1

10 years ago
See also, bug 482837 - Move icons and preview images out of the database - for a more site-wide approach
Assignee

Comment 2

10 years ago
Since this is on a schedule, I'll implement it as a BLOB, but when we move icons out of the DB for AMO, we should use the same approach for Bandwagon as well.
Assignee

Comment 3

10 years ago
Assignee

Comment 4

10 years ago
Posted patch Patch, rev. 1Splinter Review
This allows adding an icon through the API. The patch also contains some love for the simpletest framework to allow for multipart post submissions with file attachments.
Attachment #372989 - Flags: review?(lorchard)
Assignee

Updated

10 years ago
Status: NEW → ASSIGNED
OS: Mac OS X → All
Hardware: x86 → All
Moving to revised M5 milestone (4/28).
Target Milestone: --- → BW-M5
Assignee

Comment 6

10 years ago
Committed to r24626 (test framework) and r24627 (code) in order to un-block bug 456132. The tests pass, but please feel free to point out any issues you may have with this code or any changes you require.

I also added the SQL to the wiki page.
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Assignee

Updated

10 years ago
Attachment #372989 - Flags: review?(lorchard)
Verified FIXED; this has been in prod for a while, and is well-tested/used.
Status: RESOLVED → VERIFIED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.