488154 - Collection icon uploading

Status: VERIFIED FIXED

Description

[Les Orchard [:lorchard]]

We've got a placeholder for collection icons in place as of bug 487397, but a real end-to-end feature needs to be implemented for:

* accepting image uploads for collection icons
* hosting and serving uploaded collection icon images

We could stuff these into the database as blobs like addon icons, but this might be a good time to look at an alternative approach.  (eg. CDN, or at least a file system behind a static apache server somewhere.)

Comment 1

[Les Orchard [:lorchard]]

See also, bug 482837 - Move icons and preview images out of the database - for a more site-wide approach

Comment 2

[Fred Wenzel [:wenzel]]

Since this is on a schedule, I'll implement it as a BLOB, but when we move icons out of the DB for AMO, we should use the same approach for Bandwagon as well.

Comment 3

[Fred Wenzel [:wenzel]]

Created attachment 372986 [details]
SQL: add icondata BLOB

Comment 4

[Fred Wenzel [:wenzel]]

Created attachment 372989 [details] [diff] [review]
Patch, rev. 1

This allows adding an icon through the API. The patch also contains some love for the simpletest framework to allow for multipart post submissions with file attachments.

Comment 5

[Justin Scott [:fligtar]]

Moving to revised M5 milestone (4/28).

Comment 6

[Fred Wenzel [:wenzel]]

Committed to r24626 (test framework) and r24627 (code) in order to un-block bug 456132. The tests pass, but please feel free to point out any issues you may have with this code or any changes you require.

I also added the SQL to the wiki page.

Comment 7

[Stephen Donner [:stephend]]

Verified FIXED; this has been in prod for a while, and is well-tested/used.