Closed Bug 488184 Opened 14 years ago Closed 14 years ago

GTK nsIconChannel leaks its GTK icon factory (shutdown leak)

Categories

(Core :: Graphics: ImageLib, defect, P5)

All
Linux
defect

Tracking

()

RESOLVED FIXED
mozilla1.9.2a1

People

(Reporter: dbaron, Assigned: dbaron)

Details

(Keywords: memory-leak)

Attachments

(1 file)

Attached patch patchSplinter Review
The GTK nsIconChannel implementation leaks its GTK icon factory.  Freeing this on shutdown means we don't leak the icon factory object itself, plus a few icons.  (That said, GTK leaks its own global icon factory, so it doesn't help al that much.)

This patch also changes a somewhat bizarre bit of reference counting in which we seem to transfer our reference to GTK and then hold on to the pointer permanently on the assumption that GTK won't drop it.  (Well, that's usually a good assumption.)
Attachment #372467 - Flags: review?(mozbugz)
Attachment #372467 - Flags: review?(mozbugz) → review+
http://hg.mozilla.org/mozilla-central/rev/e93546bbf615
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Priority: -- → P5
Hardware: x86 → All
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
You need to log in before you can comment on or make changes to this bug.