488236 - Titlebar inconsistently shown after using bookmark button or tapping on tab

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Bookmarks, defect)

Description

[Ben Combee (:bcombee)]

Attachment: Update BrowserUI.show and the code that should call it

There were a couple of UI issues I noticed:

1) if you click on the bookmark star, you could get into a situation where the titlebar was dismissed, but the control bar was still visible, leaving a checkboard on the screen.

2) clicking on the tab that you're viewing would dismiss the titlebar but leave the tabs visible.

Comment 1

[Ben Combee (:bcombee)]

Attachment: Try #2 - reworked per Mark's suggestions on IRC

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 373190 [details] [diff] [review]
Try #2 - reworked per Mark's suggestions on IRC

you should get vlad to take a look at the WidgetStack changes, even though they are small.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

http://hg.mozilla.org/mobile-browser/rev/bfef5cca7b6f

Comment 4

[Aakash Desai [:aakashd]]

verified FIXED on builds (the titlebar stays on the screen and the sidebar is hidden after both actions):

Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.3a1pre) Gecko/20090820
Fennec/1.0b3pre

and

Mozilla/5.0 (Macintosh; U; Intel Mac OSX 10.5; en-US; rv:1.9.2a2pre)
Gecko/20090808 Fennec/1.0b3pre